Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: extensions/renderer/process_info_native_handler.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/process_info_native_handler.cc
diff --git a/extensions/renderer/process_info_native_handler.cc b/extensions/renderer/process_info_native_handler.cc
index b8fcb57343453998a393ad5ea934f075322ccc5d..adc575614e2b6dca208279609a61acf45067e20e 100644
--- a/extensions/renderer/process_info_native_handler.cc
+++ b/extensions/renderer/process_info_native_handler.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "extensions/renderer/script_context.h"
+#include "extensions/renderer/v8_maybe_helpers.h"
namespace extensions {
@@ -50,14 +51,18 @@ ProcessInfoNativeHandler::ProcessInfoNativeHandler(
void ProcessInfoNativeHandler::GetExtensionId(
const v8::FunctionCallbackInfo<v8::Value>& args) {
- args.GetReturnValue().Set(
- v8::String::NewFromUtf8(args.GetIsolate(), extension_id_.c_str()));
+ if (extension_id_.size() >= v8::String::kMaxLength)
+ return;
+ args.GetReturnValue().Set(ToV8String(args.GetIsolate(),
+ extension_id_.c_str()));
}
void ProcessInfoNativeHandler::GetContextType(
const v8::FunctionCallbackInfo<v8::Value>& args) {
- args.GetReturnValue().Set(
- v8::String::NewFromUtf8(args.GetIsolate(), context_type_.c_str()));
+ if (context_type_.size() >= v8::String::kMaxLength)
+ return;
+ args.GetReturnValue().Set(ToV8String(args.GetIsolate(),
+ context_type_.c_str()));
}
void ProcessInfoNativeHandler::InIncognitoContext(
@@ -78,7 +83,7 @@ void ProcessInfoNativeHandler::GetManifestVersion(
void ProcessInfoNativeHandler::IsSendRequestDisabled(
const v8::FunctionCallbackInfo<v8::Value>& args) {
if (send_request_disabled_) {
- args.GetReturnValue().Set(v8::String::NewFromUtf8(
+ args.GetReturnValue().Set(ToV8String(
args.GetIsolate(),
"sendRequest and onRequest are obsolete."
" Please use sendMessage and onMessage instead."));
« no previous file with comments | « extensions/renderer/object_backed_native_handler.cc ('k') | extensions/renderer/render_view_observer_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698