Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
diff --git a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
index fb95d2140c24fa23a79f41a768e34275ab28f7b8..121261add5825fb919ab86e37ee2ca85aa69f85e 100644
--- a/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
+++ b/extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc
@@ -43,7 +43,9 @@ class ScriptableObject : public gin::Wrappable<ScriptableObject>,
base::WeakPtr<MimeHandlerViewContainer> container) {
ScriptableObject* scriptable_object =
new ScriptableObject(isolate, container);
- return gin::CreateHandle(isolate, scriptable_object).ToV8()->ToObject();
+ return gin::CreateHandle(isolate, scriptable_object)
+ .ToV8()
+ .As<v8::Object>();
}
// gin::NamedPropertyInterceptor
@@ -58,8 +60,13 @@ class ScriptableObject : public gin::Wrappable<ScriptableObject>,
isolate, base::Bind(&MimeHandlerViewContainer::PostMessage,
container_, isolate)));
}
- return v8::Local<v8::FunctionTemplate>::New(
- isolate, post_message_function_template_)->GetFunction();
+ v8::Local<v8::FunctionTemplate> function_template =
+ v8::Local<v8::FunctionTemplate>::New(isolate,
+ post_message_function_template_);
+ v8::Local<v8::Function> interceptor;
+ if (function_template->GetFunction(isolate->GetCurrentContext())
+ .ToLocal(&interceptor))
+ return interceptor;
}
return v8::Local<v8::Value>();
}
« no previous file with comments | « extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc ('k') | extensions/renderer/i18n_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698