Use V8 Maybe APIs in extensions/renderer

extensions/renderer/safe_builtins.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/safe_builtins.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "extensions/renderer/script_context.h"
+#include "extensions/renderer/v8_maybe_helpers.h"
 
 namespace extensions {
 
 namespace {
 
 const char kClassName[] = "extensions::SafeBuiltins";
 
 // Documentation for makeCallback in the JavaScript, out here to reduce the
 // (very small) amount of effort that the v8 parser needs to do:
 //
@@ skipping 95 matching lines @@
     "            builtinTypes[i].prototype.toJSON = savedToJSONs[i];\n"
     "        } catch (e) {}\n"
     "      }\n"
     "    }\n"
     "  }\n"
     "});\n"
     "\n"
     "}());\n";
 
 v8::Local<v8::String> MakeKey(const char* name, v8::Isolate* isolate) {
-  return v8::String::NewFromUtf8(
-      isolate, base::StringPrintf("%s::%s", kClassName, name).c_str());
+  std::string key = base::StringPrintf("%s::%s", kClassName, name);
+  CHECK(key.size() < v8::String::kMaxLength);
+  return ToV8String(isolate, key.c_str());
 }
 
 void SaveImpl(const char* name,
               v8::Local<v8::Value> value,
               v8::Local<v8::Context> context) {
   CHECK(!value.IsEmpty() && value->IsObject()) << name;
   context->Global()->SetHiddenValue(MakeKey(name, context->GetIsolate()),
                                     value);
 }
 
 v8::Local<v8::Object> Load(const char* name, v8::Local<v8::Context> context) {
   v8::Local<v8::Value> value =
       context->Global()->GetHiddenValue(MakeKey(name, context->GetIsolate()));
   CHECK(!value.IsEmpty() && value->IsObject()) << name;
   return v8::Local<v8::Object>::Cast(value);
 }
 
 class ExtensionImpl : public v8::Extension {
  public:
   ExtensionImpl() : v8::Extension(kClassName, kScript) {}
 
  private:
   v8::Local<v8::FunctionTemplate> GetNativeFunctionTemplate(
       v8::Isolate* isolate,
       v8::Local<v8::String> name) override {
-    if (name->Equals(v8::String::NewFromUtf8(isolate, "Apply")))
+    v8::Local<v8::Context> context = isolate->GetCurrentContext();
+    if (CheckV8Call(name->Equals(context, ToV8String(isolate, "Apply"))))
       return v8::FunctionTemplate::New(isolate, Apply);
-    if (name->Equals(v8::String::NewFromUtf8(isolate, "Save")))
+    if (CheckV8Call(name->Equals(context, ToV8String(isolate, "Save"))))
       return v8::FunctionTemplate::New(isolate, Save);
     NOTREACHED() << *v8::String::Utf8Value(name);
     return v8::Local<v8::FunctionTemplate>();
   }
 
   static void Apply(const v8::FunctionCallbackInfo<v8::Value>& info) {
     CHECK(info.Length() == 5 && info[0]->IsFunction() &&  // function
           // info[1] could be an object or a string
           info[2]->IsObject() &&  // args
           info[3]->IsInt32() &&   // first_arg_index
           info[4]->IsInt32());    // args_length
     v8::Local<v8::Function> function = info[0].As<v8::Function>();
     v8::Local<v8::Object> recv;
     if (info[1]->IsObject()) {
       recv = v8::Local<v8::Object>::Cast(info[1]);
     } else if (info[1]->IsString()) {
       recv = v8::StringObject::New(v8::Local<v8::String>::Cast(info[1]))
-                 ->ToObject(info.GetIsolate());
+                 .As<v8::Object>();
     } else {
       info.GetIsolate()->ThrowException(
-          v8::Exception::TypeError(v8::String::NewFromUtf8(
+          v8::Exception::TypeError(ToV8String(
               info.GetIsolate(),
               "The first argument is the receiver and must be an object")));
       return;
     }
     v8::Local<v8::Object> args = v8::Local<v8::Object>::Cast(info[2]);
-    int first_arg_index = info[3]->ToInt32(info.GetIsolate())->Value();
-    int args_length = info[4]->ToInt32(info.GetIsolate())->Value();
+    int first_arg_index = info[3].As<v8::Int32>()->Value();
+    int args_length = info[4].As<v8::Int32>()->Value();
 
+    v8::Local<v8::Context> context = info.GetIsolate()->GetCurrentContext();
     int argc = args_length - first_arg_index;
     scoped_ptr<v8::Local<v8::Value> []> argv(new v8::Local<v8::Value>[argc]);
     for (int i = 0; i < argc; ++i) {
-      CHECK(args->Has(i + first_arg_index));
-      argv[i] = args->Get(i + first_arg_index);
+      CHECK(CheckV8Call(args->Has(context, i + first_arg_index)));
+      argv[i] = args->Get(context, i + first_arg_index).ToLocalChecked();
     }
 
-    v8::Local<v8::Value> return_value = function->Call(recv, argc, argv.get());
-    if (!return_value.IsEmpty())
+    v8::Local<v8::Value> return_value;
+    if (function->Call(context, recv, argc, argv.get()).ToLocal(&return_value))
       info.GetReturnValue().Set(return_value);
   }
 
   static void Save(const v8::FunctionCallbackInfo<v8::Value>& info) {
     CHECK(info.Length() == 2 && info[0]->IsString() && info[1]->IsObject());
     SaveImpl(*v8::String::Utf8Value(info[0]),
              info[1],
              info.GetIsolate()->GetCallingContext());
   }
 };
@@ skipping 29 matching lines @@
 
 v8::Local<v8::Object> SafeBuiltins::GetString() const {
   return Load("String", context_->v8_context());
 }
 
 v8::Local<v8::Object> SafeBuiltins::GetError() const {
   return Load("Error", context_->v8_context());
 }
 
 }  //  namespace extensions