Upstream oodles of Chrome for Android code into Chromium.

Upstream oodles of Chrome for Android code into Chromium.

This adds plenty of Android-specific code (Java, C++, and resources) in a
few new folders:
 - chrome/android/java_staging: will be merged into chrome/android/java
   in the nearish future
 - chrome/android/javatests: chrome/android/javatests_shell will be merged into
   here incrementally as ChromeShell tests are converted to run against
   ChromePublic
 - chrome/test/android/javatests_staging: will be merged into
   chrome/test/android/javatests in the nearish future

There are two important new build targets: chrome_public_apk and
chrome_public_test_apk. chrome_public_apk is similar to chrome_shell_apk, but
with even more features.

Expected effect on bot times: The new tests take about 5 minutes to run.
Initially they'll be enabled on an FYI bot, but will soon be moved to the
CQ and main bots.

BUG=484934
R=cjhopman@chromium.org, jianli@chromium.org, maruel@chromium.org, mnaganov@chromium.org, sclittle@chromium.org, tedchoc@chromium.org, yfriedman@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/7497635a7cfdae2866d2aa7a3bd2894c895b8360

[newt (away), 2015-05-20 05:17:50]

The CQ bit was checked by newt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-20 05:18:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141283003/70001

[commit-bot: I haz the power, 2015-05-20 05:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 05:50:16]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[newt (away), 2015-05-20 20:24:47]

newt@chromium.org changed reviewers:
+ tedchoc@chromium.org, yfriedman@chromium.org

[newt (away), 2015-05-20 20:24:58]

PTAL

[Ted C, 2015-05-20 20:40:37]

On 2015/05/20 20:24:58, newt wrote:
> PTAL

the rubberiest of rubber stamp lgtm

[Yaron, 2015-05-20 21:12:09]

tl;dr lgtm :)

On Wed, May 20, 2015 at 4:40 PM <tedchoc@chromium.org> wrote:

> On 2015/05/20 20:24:58, newt wrote:
> > PTAL
>
> the rubberiest of rubber stamp lgtm
>
> https://codereview.chromium.org/1141283003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[newt (away), 2015-05-20 21:26:34]

newt@chromium.org changed reviewers:
+ cjhopman@chromium.org, maruel@chromium.org

[newt (away), 2015-05-20 21:26:39]

cjhopman: please review build/all.gyp in patch set 10 (other patch sets have
different changes to all.gyp, which are only for the purposes of running
tryjobs)
maruel: please review chrome/chrome_public_test_apk.isolate

For background: this CL was generated automatically by move_files_to_chromium.py
(in clank), according to the plan in this design doc:
https://docs.google.com/document/d/1o3GRRmEs1AzmlTDF4g6vl1E-njQRAX_iKLcKjuTnP...
Everything else has been reviewed as individual CLs in clank.

[cjhopman, 2015-05-20 21:34:10]

lgtm

[newt (away), 2015-05-20 21:36:02]

On 2015/05/20 21:34:10, cjhopman wrote:
> lgtm

err, *this* design doc:
https://docs.google.com/document/d/11h-jvFgkE3Hxl8lbZtKCiE5DHutG2WCjnclYP_-HcEg

[M-A Ruel, 2015-05-20 21:39:31]

Could you checkin the >1000 resources files first, then the reviewable code
as a second CL?

2015-05-20 17:36 GMT-04:00 <newt@chromium.org>:

> On 2015/05/20 21:34:10, cjhopman wrote:
>
>> lgtm
>>
>
> err, *this* design doc:
>
>
https://docs.google.com/document/d/11h-jvFgkE3Hxl8lbZtKCiE5DHutG2WCjnclYP_-HcEg
>
> https://codereview.chromium.org/1141283003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[newt (away), 2015-05-20 21:46:53]

On 2015/05/20 21:39:31, M-A Ruel wrote:
> Could you checkin the >1000 resources files first, then the reviewable code
> as a second CL?

Yes, that's an option. Though, there are still hundreds of non-resource files
and none of them are expected to be reviewed as part of this CL except all.gyp
and the isolate file.

[M-A Ruel, 2015-05-20 21:51:23]

2015-05-20 17:46 GMT-04:00 <newt@chromium.org>:

> On 2015/05/20 21:39:31, M-A Ruel wrote:
>
>> Could you checkin the >1000 resources files first, then the reviewable
>> code
>> as a second CL?
>>
>
> Yes, that's an option. Though, there are still hundreds of non-resource
> files
> and none of them are expected to be reviewed as part of this CL except
> all.gyp
> and the isolate file.
>

Well, the CL is so large that I can't review anyway, so please do it in two
phases. It's fairly trivial to do in git.

M-A

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-05-20 22:02:10]

Looks like there's a hidden ball of pain underneath that I have the joy to
never have to suffer from.

lgtm as I manually looked at the isolate file.

M-A

2015-05-20 17:51 GMT-04:00 Marc-Antoine Ruel <maruel@chromium.org>:

> 2015-05-20 17:46 GMT-04:00 <newt@chromium.org>:
>
>> On 2015/05/20 21:39:31, M-A Ruel wrote:
>>
>>> Could you checkin the >1000 resources files first, then the reviewable
>>> code
>>> as a second CL?
>>>
>>
>> Yes, that's an option. Though, there are still hundreds of non-resource
>> files
>> and none of them are expected to be reviewed as part of this CL except
>> all.gyp
>> and the isolate file.
>>
>
> Well, the CL is so large that I can't review anyway, so please do it in
> two phases. It's fairly trivial to do in git.
>
> M-A
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[M-A Ruel, 2015-05-20 22:04:21]

lgtm

[newt (away), 2015-05-20 23:04:01]

newt@chromium.org changed reviewers:
+ jianli@chromium.org, mnaganov@chromium.org, sclittle@chromium.org

[newt (away), 2015-05-20 23:04:07]

sclittle: PTAL at new components/precache DEPS entries in java_staging/DEPS and
javatests/DEPS
mnaganov: PTAL at new components/navigation_interception DEPS entries in
java_staging/DEPS and javatests/DEPS
jianli: PTAL at new components/gcm_driver DEPS entries in java_staging/DEPS and
javatests/DEPS

Direct link to java_staging/DEPS:
https://codereview.chromium.org/1141283003/patch/100001/5453424262905856
Direct link to javatests/DEPS:
https://codereview.chromium.org/1141283003/patch/100001/5385170253250560

Note: these two DEPS files have been copied from corresponding existing folders:
 - java_staging/DEPS was copied from java/DEPS
 - javatests/DEPS was copied from javatests_shell/DEPS

Soon, java_staging will be merged with java, and javatests will be merged with
javatests_shell, so conceptually this change doesn't add any new deps. But we
need to duplicate these DEPS files temporarily to make the bots happy.

[mnaganov (inactive), 2015-05-20 23:11:22]

On 2015/05/20 23:04:07, newt wrote:
> sclittle: PTAL at new components/precache DEPS entries in java_staging/DEPS
and
> javatests/DEPS
> mnaganov: PTAL at new components/navigation_interception DEPS entries in
> java_staging/DEPS and javatests/DEPS
> jianli: PTAL at new components/gcm_driver DEPS entries in java_staging/DEPS
and
> javatests/DEPS
> 
> Direct link to java_staging/DEPS:
> https://codereview.chromium.org/1141283003/patch/100001/5453424262905856
> Direct link to javatests/DEPS:
> https://codereview.chromium.org/1141283003/patch/100001/5385170253250560
> 
> Note: these two DEPS files have been copied from corresponding existing
folders:
>  - java_staging/DEPS was copied from java/DEPS
>  - javatests/DEPS was copied from javatests_shell/DEPS
> 
> Soon, java_staging will be merged with java, and javatests will be merged with
> javatests_shell, so conceptually this change doesn't add any new deps. But we
> need to duplicate these DEPS files temporarily to make the bots happy.

The aforementioned entries LGTM :)

[newt (away), 2015-05-20 23:59:53]

The CQ bit was checked by newt@chromium.org to run a CQ dry run

[newt (away), 2015-05-20 23:59:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, cjhopman@chromium.org, maruel@chromium.org,
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/1141283003/#ps110001
(title: "fix deps")

[commit-bot: I haz the power, 2015-05-21 00:00:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141283003/110001

[sclittle, 2015-05-21 00:06:53]

lgtm

[commit-bot: I haz the power, 2015-05-21 00:30:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 00:30:53]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jianli, 2015-05-21 00:44:57]

components/gcm_driver DEPS lgtm

[newt (away), 2015-05-21 01:41:04]

The CQ bit was checked by newt@chromium.org to run a CQ dry run

[newt (away), 2015-05-21 01:41:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnaganov@chromium.org, sclittle@chromium.org, maruel@chromium.org,
jianli@chromium.org, tedchoc@chromium.org, cjhopman@chromium.org
Link to the patchset: https://codereview.chromium.org/1141283003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-05-21 01:42:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141283003/120001

[Yaron, 2015-05-21 02:16:10]

LGTM

On Wed, May 20, 2015 at 8:44 PM <jianli@chromium.org> wrote:

> components/gcm_driver DEPS lgtm
>
> https://codereview.chromium.org/1141283003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Yaron, 2015-05-21 02:35:39]

On 2015/05/21 at 02:16:10, Yaron wrote:
> LGTM
> 
> On Wed, May 20, 2015 at 8:44 PM <jianli@chromium.org> wrote:
> 
> > components/gcm_driver DEPS lgtm
> >
> > https://codereview.chromium.org/1141283003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email to chromium-reviews+unsubscribe@chromium.org.
> 

lgtm

[aurimas (slooooooooow), 2015-05-21 02:36:13]

Finally! http://imgur.com/OY4irNz

[commit-bot: I haz the power, 2015-05-21 02:41:51]

Patchset 14 (id:??) landed as
https://crrev.com/7497635a7cfdae2866d2aa7a3bd2894c895b8360
Cr-Commit-Position: refs/heads/master@{#330877}

[newt (away), 2015-05-21 02:41:57]

Committed patchset #14 (id:130001) manually as
7497635a7cfdae2866d2aa7a3bd2894c895b8360 (tree was closed).

[Nico, 2015-07-24 22:00:35]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-24 22:00:38]

We already had
chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks. This
adds enhancedbookmarks (without a _) right next to it. That's hopefully not
intentional? :-)

[newt (away), 2015-07-24 22:10:38]

Not intentional indeed. I'll move them into the same directory now.

On Fri, Jul 24, 2015 at 3:00 PM, <thakis@chromium.org> wrote:

> We already had
> chrome/android/java/src/org/chromium/chrome/browser/enhanced_bookmarks.
> This
> adds enhancedbookmarks (without a _) right next to it. That's hopefully not
> intentional? :-)
>
> https://codereview.chromium.org/1141283003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-07-24 22:24:31]

Thanks!

The two files added in chrome/browser/android/bookmark should probably go into
	chrome/browser/android/bookmarks (with trailing s) too.

[Nico, 2015-08-04 18:28:50]

Looks like
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks
and chrome/browser/android/bookmark are still around. Ping? :-)

On Fri, Jul 24, 2015 at 3:24 PM, <thakis@chromium.org> wrote:

> Thanks!
>
> The two files added in chrome/browser/android/bookmark should probably go
> into
>         chrome/browser/android/bookmarks (with trailing s) too.
>
> https://codereview.chromium.org/1141283003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[newt (away), 2015-08-04 18:50:06]

enhanced_bookmarks is gone. Just uploaded a CL
<https://codereview.chromium.org/1264653005/> to merge the
chrome/browser/android/bookmark[s] folders.

On Tue, Aug 4, 2015 at 11:28 AM, Nico Weber <thakis@chromium.org> wrote:

> Looks like
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks
> and chrome/browser/android/bookmark are still around. Ping? :-)
>
> On Fri, Jul 24, 2015 at 3:24 PM, <thakis@chromium.org> wrote:
>
>> Thanks!
>>
>> The two files added in chrome/browser/android/bookmark should probably go
>> into
>>         chrome/browser/android/bookmarks (with trailing s) too.
>>
>> https://codereview.chromium.org/1141283003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.