Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 1264653005: Merge chrome/browser/android/bookmark[s] folders. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 4 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge chrome/browser/android/bookmark[s] folders. No need for a "bookmark" folder and a "bookmarks" folder. Committed: https://crrev.com/35fd88c871bd02ad9d7982775d8dd9b0119cadcd Cr-Commit-Position: refs/heads/master@{#341954}

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -60 lines) Patch
D chrome/browser/android/bookmark/edit_bookmark_helper.h View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/browser/android/bookmark/edit_bookmark_helper.cc View 1 chunk +0 lines, -41 lines 0 comments Download
A + chrome/browser/android/bookmarks/edit_bookmark_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/bookmarks/edit_bookmark_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
newt (away)
PTAL
5 years, 4 months ago (2015-08-04 18:49:10 UTC) #2
Yusuf
lgtm
5 years, 4 months ago (2015-08-05 00:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264653005/1
5 years, 4 months ago (2015-08-05 00:55:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/99406)
5 years, 4 months ago (2015-08-05 01:06:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264653005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264653005/20001
5 years, 4 months ago (2015-08-05 19:03:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 20:17:27 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 20:18:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35fd88c871bd02ad9d7982775d8dd9b0119cadcd
Cr-Commit-Position: refs/heads/master@{#341954}

Powered by Google App Engine
This is Rietveld 408576698