Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, zea+watch_chromium.org, hashimoto+watch_chromium.org, tzik, tfarina, maxbogue+watch_chromium.org, nhiroki, asvitkine+watch_chromium.org, pvalenzuela+watch_chromium.org, rginda+watch_chromium.org, plaree+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ BUG=466848 Committed: https://crrev.com/6e2d1deffacba393727d5e2d40cf38d5647ec703 Cr-Commit-Position: refs/heads/master@{#322463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -593 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/boot_times_recorder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/camera_detector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_document.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/device/input_service_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 20 chunks +24 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/drive/debug_info_collector.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.cc View 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/drive/download_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/drive_file_stream_reader.cc View 17 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_file_system.cc View 14 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 44 chunks +51 lines, -51 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/copy_operation.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_directory_operation.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/create_file_operation.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/download_operation.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/open_file_operation.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/remove_operation.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/set_property_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/touch_operation.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/file_write_watcher.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/async_file_util.cc View 18 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 44 chunks +49 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_revert_performer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/remove_performer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/write_on_cache_file.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 12 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 18 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_function_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/external_metrics.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/help_app_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/screens/update_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_throttle.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_xhr_request_waiter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_verifier.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_token_fetcher.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc View 11 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/memory/low_memory_observer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/mobile_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_nss.cc View 20 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/command_line_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system_logs/touch_log_source_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@oshima: please take a look.
5 years, 9 months ago (2015-03-25 20:23:03 UTC) #2
oshima
lgtm lgtm
5 years, 9 months ago (2015-03-26 18:27:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1036723003/1
5 years, 9 months ago (2015-03-26 20:01:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 20:40:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 20:41:25 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6e2d1deffacba393727d5e2d40cf38d5647ec703
Cr-Commit-Position: refs/heads/master@{#322463}

Powered by Google App Engine
This is Rietveld 408576698