chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/download_operation.cc ('k') | chrome/browser/chromeos/drive/file_system/move_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc

diff --git a/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc b/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc

index 8dc69b8b9a5d03a6bd67489117047d5fb090c2d5..0709a1dcc56cbebb9ad1b4f17b886c9fc82ff347 100644

--- a/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc

+++ b/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc

@@ -69,7 +69,7 @@ GetFileForSavingOperation::~GetFileForSavingOperation() {

void GetFileForSavingOperation::GetFileForSaving(

const base::FilePath& file_path,

const GetFileCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

create_file_operation_->CreateFile(

@@ -86,7 +86,7 @@ void GetFileForSavingOperation::GetFileForSavingAfterCreate(

const base::FilePath& file_path,

const GetFileCallback& callback,

FileError error) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

if (error != FILE_ERROR_OK) {

@@ -109,7 +109,7 @@ void GetFileForSavingOperation::GetFileForSavingAfterDownload(

FileError error,

const base::FilePath& cache_path,

scoped_ptr<ResourceEntry> entry) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

if (error != FILE_ERROR_OK) {

@@ -144,7 +144,7 @@ void GetFileForSavingOperation::GetFileForSavingAfterOpenForWrite(

scoped_ptr<ResourceEntry> entry,

scoped_ptr<base::ScopedClosureRunner>* file_closer,

FileError error) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

if (error != FILE_ERROR_OK) {

@@ -171,7 +171,7 @@ void GetFileForSavingOperation::GetFileForSavingAfterWatch(

const base::FilePath& cache_path,

scoped_ptr<ResourceEntry> entry,

bool success) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

logger_->Log(logging::LOG_INFO, "Started watching modification to %s [%s].",