chrome/browser/chromeos/drive/file_system/set_property_operation.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/set_property_operation.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/search_operation.cc ('k') | chrome/browser/chromeos/drive/file_system/touch_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/set_property_operation.cc

diff --git a/chrome/browser/chromeos/drive/file_system/set_property_operation.cc b/chrome/browser/chromeos/drive/file_system/set_property_operation.cc

index 8226957dd040da4486eb6f0e09ccf9f86fcb270b..111f9b79a188645d8e9da2af56733de3c9a7db72 100644

--- a/chrome/browser/chromeos/drive/file_system/set_property_operation.cc

+++ b/chrome/browser/chromeos/drive/file_system/set_property_operation.cc

@@ -90,7 +90,7 @@ void SetPropertyOperation::SetProperty(

const std::string& key,

const std::string& value,

const FileOperationCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

ResourceEntry* entry = new ResourceEntry;

@@ -106,7 +106,7 @@ void SetPropertyOperation::SetPropertyAfterUpdateLocalState(

const FileOperationCallback& callback,

const ResourceEntry* entry,

FileError result) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

if (result == FILE_ERROR_OK) {