chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc ('k') | chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc

diff --git a/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc b/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc

index 6ec846cbbc7ce860ca8395c4204deec26baa1eb4..87a8cc7938e7da159914b62b04da2ad5531e5daa 100644

--- a/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc

+++ b/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_reader_impl.cc

@@ -42,7 +42,7 @@ WebkitFileStreamReaderImpl::~WebkitFileStreamReaderImpl() {

int WebkitFileStreamReaderImpl::Read(net::IOBuffer* buffer,

int buffer_length,

const net::CompletionCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(stream_reader_);

DCHECK(buffer);

DCHECK(!callback.is_null());

@@ -67,7 +67,7 @@ int WebkitFileStreamReaderImpl::Read(net::IOBuffer* buffer,

int64 WebkitFileStreamReaderImpl::GetLength(

const net::Int64CompletionCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(stream_reader_);

DCHECK(!callback.is_null());

@@ -94,7 +94,7 @@ void WebkitFileStreamReaderImpl::OnStreamReaderInitialized(

const net::CompletionCallback& callback,

int error,

scoped_ptr<ResourceEntry> entry) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(stream_reader_);

DCHECK(!callback.is_null());

@@ -117,7 +117,7 @@ void WebkitFileStreamReaderImpl::ReadAfterStreamReaderInitialized(

int buffer_length,

const net::CompletionCallback& callback,

int initialization_result) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(!callback.is_null());

if (initialization_result != net::OK) {

@@ -134,7 +134,7 @@ void WebkitFileStreamReaderImpl::ReadAfterStreamReaderInitialized(

void WebkitFileStreamReaderImpl::GetLengthAfterStreamReaderInitialized(

const net::Int64CompletionCallback& callback,

int initialization_result) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(!callback.is_null());

if (initialization_result != net::OK) {