Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
diff --git a/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc b/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
index 9c5ca41aa2e21a2156e846cb72a16e411157276c..9339c1fde4d9d2bd9d49f39663236b4f73f6324c 100644
--- a/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
+++ b/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
@@ -133,7 +133,7 @@ SupervisedUserManagerImpl::SupervisedUserManagerImpl(
ChromeUserManagerImpl* owner)
: owner_(owner), cros_settings_(CrosSettings::Get()) {
// SupervisedUserManager instance should be used only on UI thread.
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
authentication_.reset(new SupervisedUserAuthentication(this));
}
@@ -357,7 +357,7 @@ void SupervisedUserManagerImpl::SetUserBooleanValue(const std::string& user_id,
const user_manager::User* SupervisedUserManagerImpl::FindByDisplayName(
const base::string16& display_name) const {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
const user_manager::UserList& users = owner_->GetUsers();
for (user_manager::UserList::const_iterator it = users.begin();
it != users.end();
@@ -372,7 +372,7 @@ const user_manager::User* SupervisedUserManagerImpl::FindByDisplayName(
const user_manager::User* SupervisedUserManagerImpl::FindBySyncId(
const std::string& sync_id) const {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
const user_manager::UserList& users = owner_->GetUsers();
for (user_manager::UserList::const_iterator it = users.begin();
it != users.end();

Powered by Google App Engine
This is Rietveld 408576698