chrome/browser/chromeos/device/input_service_proxy.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/device/input_service_proxy.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/customization/customization_document.cc ('k') | chrome/browser/chromeos/drive/change_list_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/device/input_service_proxy.cc

diff --git a/chrome/browser/chromeos/device/input_service_proxy.cc b/chrome/browser/chromeos/device/input_service_proxy.cc

index 3d27ab1498f03ca82f21c01861aef041fdf5387f..1a18319877c7dc65d5aa177e1b8abc70ce540685 100644

--- a/chrome/browser/chromeos/device/input_service_proxy.cc

+++ b/chrome/browser/chromeos/device/input_service_proxy.cc

@@ -20,7 +20,7 @@ BrowserThread::ID InputServiceProxy::thread_identifier_ = BrowserThread::FILE;

class InputServiceProxy::ServiceObserver : public InputServiceLinux::Observer {

public:

- ServiceObserver() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); }

+ ServiceObserver() { DCHECK_CURRENTLY_ON(BrowserThread::UI); }

~ServiceObserver() override { DCHECK(CalledOnValidThread()); }

void Initialize(const base::WeakPtr<InputServiceProxy>& proxy) {

@@ -89,7 +89,7 @@ InputServiceProxy::InputServiceProxy()

task_runner_(BrowserThread::GetMessageLoopProxyForThread(

thread_identifier_)),

weak_factory_(this) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

task_runner_->PostTask(

FROM_HERE,

base::Bind(&InputServiceProxy::ServiceObserver::Initialize,