chrome/browser/chromeos/platform_keys/platform_keys_service.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/platform_keys/platform_keys_service.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/platform_keys/platform_keys_nss.cc ('k') | chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/platform_keys/platform_keys_service.cc

diff --git a/chrome/browser/chromeos/platform_keys/platform_keys_service.cc b/chrome/browser/chromeos/platform_keys/platform_keys_service.cc

index 34228d3b0f2c168299a831d5fe79e4d181a1215f..d4c38a66f3bdbe549cac32bb84082b2ed1fc8208 100644

--- a/chrome/browser/chromeos/platform_keys/platform_keys_service.cc

+++ b/chrome/browser/chromeos/platform_keys/platform_keys_service.cc

@@ -651,7 +651,7 @@ void PlatformKeysService::GenerateRSAKey(const std::string& token_id,

unsigned int modulus_length,

const std::string& extension_id,

const GenerateKeyCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

platform_keys::subtle::GenerateRSAKey(

token_id, modulus_length,

@@ -667,7 +667,7 @@ void PlatformKeysService::SignRSAPKCS1Digest(

platform_keys::HashAlgorithm hash_algorithm,

const std::string& extension_id,

const SignCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

StartOrQueueTask(make_scoped_ptr(new SignTask(

token_id, data, public_key, false /* digest before signing */,

hash_algorithm, extension_id, callback, this)));

@@ -678,7 +678,7 @@ void PlatformKeysService::SignRSAPKCS1Raw(const std::string& token_id,

const std::string& public_key,

const std::string& extension_id,

const SignCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

StartOrQueueTask(make_scoped_ptr(new SignTask(

token_id, data, public_key, true /* sign directly without hashing */,

platform_keys::HASH_ALGORITHM_NONE, extension_id, callback, this)));

@@ -690,7 +690,7 @@ void PlatformKeysService::SelectClientCertificates(

const std::string& extension_id,

const SelectCertificatesCallback& callback,

content::WebContents* web_contents) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

StartOrQueueTask(make_scoped_ptr(new SelectTask(

request, interactive, extension_id, callback, web_contents, this)));

}