Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/chromeos/offline/offline_load_page.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/offline/offline_load_page.cc
diff --git a/chrome/browser/chromeos/offline/offline_load_page.cc b/chrome/browser/chromeos/offline/offline_load_page.cc
index 55f590eebd02d9d326017eec6549b75be7e61c3f..2e80a2251580236d4367635042fb76dbd1b85cfd 100644
--- a/chrome/browser/chromeos/offline/offline_load_page.cc
+++ b/chrome/browser/chromeos/offline/offline_load_page.cc
@@ -60,7 +60,7 @@ OfflineLoadPage::OfflineLoadPage(WebContents* web_contents,
}
OfflineLoadPage::~OfflineLoadPage() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
}
@@ -111,13 +111,13 @@ void OfflineLoadPage::OverrideRendererPrefs(
}
void OfflineLoadPage::OnProceed() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
proceeded_ = true;
NotifyBlockingPageComplete(true);
}
void OfflineLoadPage::OnDontProceed() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Ignore if it's already proceeded.
if (proceeded_)
return;
@@ -157,7 +157,7 @@ void OfflineLoadPage::NotifyBlockingPageComplete(bool proceed) {
void OfflineLoadPage::OnConnectionTypeChanged(
net::NetworkChangeNotifier::ConnectionType type) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
const bool online = type != net::NetworkChangeNotifier::CONNECTION_NONE;
DVLOG(1) << "ConnectionTypeObserver notification received: state="
<< (online ? "online" : "offline");
« no previous file with comments | « chrome/browser/chromeos/mobile_config.cc ('k') | chrome/browser/chromeos/platform_keys/platform_keys_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698