chrome/browser/chromeos/external_metrics.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/external_metrics.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/wallpaper_function_base.cc ('k') | chrome/browser/chromeos/fileapi/external_file_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/external_metrics.cc

diff --git a/chrome/browser/chromeos/external_metrics.cc b/chrome/browser/chromeos/external_metrics.cc

index d9fe9cdda4a5193ad247404ad21ddd3f08e0fed9..2f1d1f95705faad6485c10238b1cf8990b336edc 100644

--- a/chrome/browser/chromeos/external_metrics.cc

+++ b/chrome/browser/chromeos/external_metrics.cc

@@ -50,7 +50,7 @@ bool CheckLinearValues(const std::string& name, int maximum) {

// Establishes field trial for wifi scanning in chromeos. crbug.com/242733.

void SetupProgressiveScanFieldTrial() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

const char name_of_experiment[] = "ProgressiveScan";

const base::FilePath group_file_path(

"/home/chronos/.progressive_scan_variation");

@@ -251,7 +251,7 @@ void ExternalMetrics::ScheduleCollector() {

}

void ExternalMetrics::SetupFieldTrialsOnFileThread() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);

// Field trials that do not read from files can be initialized in

// ExternalMetrics::Start() above.

SetupProgressiveScanFieldTrial();