chrome/browser/chromeos/login/screens/update_screen.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/update_screen.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/profile_auth_data.cc ('k') | chrome/browser/chromeos/login/screens/user_image_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/screens/update_screen.cc

diff --git a/chrome/browser/chromeos/login/screens/update_screen.cc b/chrome/browser/chromeos/login/screens/update_screen.cc

index ca9d4fc8788c8c8e9237eabf5f52c3cc70e948ec..310f95f1cbd242e85fca9be897c926b4b3c7409f 100644

--- a/chrome/browser/chromeos/login/screens/update_screen.cc

+++ b/chrome/browser/chromeos/login/screens/update_screen.cc

@@ -83,7 +83,7 @@ void StartUpdateCallback(UpdateScreen* screen,

// static

UpdateScreen::InstanceSet& UpdateScreen::GetInstanceSet() {

CR_DEFINE_STATIC_LOCAL(std::set<UpdateScreen*>, instance_set, ());

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); // not threadsafe.

+ DCHECK_CURRENTLY_ON(BrowserThread::UI); // not threadsafe.

return instance_set;

}

« no previous file with comments | « chrome/browser/chromeos/login/profile_auth_data.cc ('k') | chrome/browser/chromeos/login/screens/user_image_screen.cc » ('j') | no next file with comments »