chrome/browser/chromeos/extensions/wallpaper_function_base.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_function_base.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc ('k') | chrome/browser/chromeos/external_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/wallpaper_function_base.cc

diff --git a/chrome/browser/chromeos/extensions/wallpaper_function_base.cc b/chrome/browser/chromeos/extensions/wallpaper_function_base.cc

index 3adda8e587dfbcd34d9575b99900078dda620506..703a57268d2d48dede95330cd5ad326fed600c46 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_function_base.cc

+++ b/chrome/browser/chromeos/extensions/wallpaper_function_base.cc

@@ -49,7 +49,7 @@ class WallpaperFunctionBase::UnsafeWallpaperDecoder

}

void Start(const std::vector<char>& image_data) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// This function can only be called after user login. It is fine to use

// unsafe image decoder here. Before user login, a robust jpeg decoder will

@@ -109,7 +109,7 @@ WallpaperFunctionBase::~WallpaperFunctionBase() {

}

void WallpaperFunctionBase::StartDecode(const std::vector<char>& data) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (unsafe_wallpaper_decoder_)

unsafe_wallpaper_decoder_->Cancel();

unsafe_wallpaper_decoder_ = new UnsafeWallpaperDecoder(this);