Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: chrome/browser/chromeos/drive/file_system/download_operation.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/file_system/download_operation.cc
diff --git a/chrome/browser/chromeos/drive/file_system/download_operation.cc b/chrome/browser/chromeos/drive/file_system/download_operation.cc
index 8c0f165f376d7e445cbea60465ec3922daed642d..1aeb5e7a2c19db7d682a4bd81319315222406c42 100644
--- a/chrome/browser/chromeos/drive/file_system/download_operation.cc
+++ b/chrome/browser/chromeos/drive/file_system/download_operation.cc
@@ -360,7 +360,7 @@ base::Closure DownloadOperation::EnsureFileDownloadedByLocalId(
const GetFileContentInitializedCallback& initialized_callback,
const google_apis::GetContentCallback& get_content_callback,
const GetFileCallback& completion_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!completion_callback.is_null());
CheckPreconditionForEnsureFileDownloadedParams params;
@@ -401,7 +401,7 @@ base::Closure DownloadOperation::EnsureFileDownloadedByPath(
const GetFileContentInitializedCallback& initialized_callback,
const google_apis::GetContentCallback& get_content_callback,
const GetFileCallback& completion_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!completion_callback.is_null());
CheckPreconditionForEnsureFileDownloadedParams params;
@@ -442,7 +442,7 @@ void DownloadOperation::EnsureFileDownloadedAfterCheckPreCondition(
base::FilePath* cache_file_path,
base::FilePath* temp_download_file_path,
FileError error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(params);
DCHECK(drive_file_path);
DCHECK(cache_file_path);
@@ -489,7 +489,7 @@ void DownloadOperation::EnsureFileDownloadedAfterDownloadFile(
scoped_ptr<DownloadParams> params,
google_apis::DriveApiErrorCode gdata_error,
const base::FilePath& downloaded_file_path) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DownloadParams* params_ptr = params.get();
ResourceEntry* entry_after_update = new ResourceEntry;
@@ -519,7 +519,7 @@ void DownloadOperation::EnsureFileDownloadedAfterUpdateLocalState(
scoped_ptr<ResourceEntry> entry_after_update,
base::FilePath* cache_file_path,
FileError error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (error != FILE_ERROR_OK) {
params->OnError(error);

Powered by Google App Engine
This is Rietveld 408576698