Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4995)

Unified Diff: chrome/browser/chromeos/drive/file_write_watcher.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/file_write_watcher.cc
diff --git a/chrome/browser/chromeos/drive/file_write_watcher.cc b/chrome/browser/chromeos/drive/file_write_watcher.cc
index 0affb5f1d4cb294d2ee11580a0e770789b5fcee7..48d750095e30e085f06776e4db3482989589cb99 100644
--- a/chrome/browser/chromeos/drive/file_write_watcher.cc
+++ b/chrome/browser/chromeos/drive/file_write_watcher.cc
@@ -80,11 +80,11 @@ class FileWriteWatcher::FileWriteWatcherImpl {
FileWriteWatcher::FileWriteWatcherImpl::FileWriteWatcherImpl()
: delay_(base::TimeDelta::FromSeconds(kWriteEventDelayInSeconds)),
weak_ptr_factory_(this) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
}
void FileWriteWatcher::FileWriteWatcherImpl::Destroy() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Just forwarding the call to FILE thread.
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)->PostTask(
@@ -97,7 +97,7 @@ void FileWriteWatcher::FileWriteWatcherImpl::StartWatch(
const base::FilePath& path,
const StartWatchCallback& on_start_callback,
const base::Closure& on_write_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
// Forwarding the call to FILE thread and relaying the |callback|.
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)->PostTask(
@@ -110,13 +110,13 @@ void FileWriteWatcher::FileWriteWatcherImpl::StartWatch(
}
FileWriteWatcher::FileWriteWatcherImpl::~FileWriteWatcherImpl() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
STLDeleteContainerPairSecondPointers(watchers_.begin(), watchers_.end());
}
void FileWriteWatcher::FileWriteWatcherImpl::DestroyOnFileThread() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
delete this;
}
@@ -125,7 +125,7 @@ void FileWriteWatcher::FileWriteWatcherImpl::StartWatchOnFileThread(
const base::FilePath& path,
const StartWatchCallback& on_start_callback,
const base::Closure& on_write_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
std::map<base::FilePath, PathWatchInfo*>::iterator it = watchers_.find(path);
if (it != watchers_.end()) {
@@ -149,7 +149,7 @@ void FileWriteWatcher::FileWriteWatcherImpl::StartWatchOnFileThread(
void FileWriteWatcher::FileWriteWatcherImpl::OnWriteEvent(
const base::FilePath& path,
bool error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
if (error)
return;
@@ -170,7 +170,7 @@ void FileWriteWatcher::FileWriteWatcherImpl::OnWriteEvent(
void FileWriteWatcher::FileWriteWatcherImpl::InvokeCallback(
const base::FilePath& path) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
std::map<base::FilePath, PathWatchInfo*>::iterator it = watchers_.find(path);
DCHECK(it != watchers_.end());
@@ -186,17 +186,17 @@ void FileWriteWatcher::FileWriteWatcherImpl::InvokeCallback(
FileWriteWatcher::FileWriteWatcher()
: watcher_impl_(new FileWriteWatcherImpl) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
}
FileWriteWatcher::~FileWriteWatcher() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
}
void FileWriteWatcher::StartWatch(const base::FilePath& file_path,
const StartWatchCallback& on_start_callback,
const base::Closure& on_write_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
watcher_impl_->StartWatch(file_path, on_start_callback, on_write_callback);
}
« no previous file with comments | « chrome/browser/chromeos/drive/file_system_util.cc ('k') | chrome/browser/chromeos/drive/fileapi/async_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698