chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/event_router.cc ('k') | chrome/browser/chromeos/extensions/file_manager/private_api_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc b/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

index 9adacf691c4ea358435549815a200a61f2070d50..f213af5c3c687eb4d6a60bd1792fba5be977e42e 100644

--- a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

@@ -188,7 +188,7 @@ bool FileSelectorImpl::StartSelectFile(

const base::FilePath& suggested_name,

const std::vector<std::string>& allowed_extensions,

Browser* browser) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!dialog_.get());

DCHECK(browser);

@@ -240,7 +240,7 @@ void FileSelectorImpl::FileSelectionCanceled(

void FileSelectorImpl::SendResponse(bool success,

const base::FilePath& selected_path) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// We don't want to send multiple responses.

if (function_.get())

@@ -308,7 +308,7 @@ bool FileBrowserHandlerInternalSelectFileFunction::RunAsync() {

void FileBrowserHandlerInternalSelectFileFunction::OnFilePathSelected(

bool success,

const base::FilePath& full_path) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

if (!success) {

Respond(EntryDefinition(), false);