chrome/browser/chromeos/drive/file_system/create_directory_operation.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/create_directory_operation.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_system/copy_operation.cc ('k') | chrome/browser/chromeos/drive/file_system/create_file_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/create_directory_operation.cc

diff --git a/chrome/browser/chromeos/drive/file_system/create_directory_operation.cc b/chrome/browser/chromeos/drive/file_system/create_directory_operation.cc

index 9a8098a9b7379a5f2a2518905eb66d34cb403dfd..b746b2d26893dbedde4a64733bc402ec14b07b0b 100644

--- a/chrome/browser/chromeos/drive/file_system/create_directory_operation.cc

+++ b/chrome/browser/chromeos/drive/file_system/create_directory_operation.cc

@@ -128,11 +128,11 @@ CreateDirectoryOperation::CreateDirectoryOperation(

delegate_(delegate),

metadata_(metadata),

weak_ptr_factory_(this) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

}

CreateDirectoryOperation::~CreateDirectoryOperation() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

}

void CreateDirectoryOperation::CreateDirectory(

@@ -140,7 +140,7 @@ void CreateDirectoryOperation::CreateDirectory(

bool is_exclusive,

bool is_recursive,

const FileOperationCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

std::set<std::string>* updated_local_ids = new std::set<std::string>;

@@ -168,7 +168,7 @@ void CreateDirectoryOperation::CreateDirectoryAfterUpdateLocalState(

const std::set<std::string>* updated_local_ids,

const FileChange* changed_files,

FileError error) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

for (const auto& id : *updated_local_ids) {