Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3904)

Unified Diff: chrome/browser/chromeos/drive/fileapi/async_file_util.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/fileapi/async_file_util.cc
diff --git a/chrome/browser/chromeos/drive/fileapi/async_file_util.cc b/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
index 9adf7871e25c3caba7a8a267fa31299a5c44aff4..904d601b25cc081ccf9efa5378bceaeb58342c11 100644
--- a/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
+++ b/chrome/browser/chromeos/drive/fileapi/async_file_util.cc
@@ -48,7 +48,7 @@ void PostFileSystemCallback(
const fileapi_internal::FileSystemGetter& file_system_getter,
const base::Callback<void(FileSystemInterface*)>& function,
const base::Closure& on_error_callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
BrowserThread::PostTask(
BrowserThread::UI,
@@ -67,7 +67,7 @@ void RunCreateOrOpenFileCallback(
const AsyncFileUtil::CreateOrOpenCallback& callback,
base::File file,
const base::Closure& close_callback_on_ui_thread) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
// It is necessary to make a closure, which runs on file closing here.
// It will be provided as a FileSystem::OpenFileCallback's argument later.
@@ -90,7 +90,7 @@ void RunCreateOrOpenFileCallbackOnError(
void RunEnsureFileExistsCallback(
const AsyncFileUtil::EnsureFileExistsCallback& callback,
base::File::Error error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
// Remember if the file is actually created or not.
bool created = (error == base::File::FILE_OK);
@@ -112,7 +112,7 @@ void RunCreateSnapshotFileCallback(
// ShareableFileReference is thread *unsafe* class. So it is necessary to
// create the instance (by invoking GetOrCreate) on IO thread, though
// most drive file system related operations run on UI thread.
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
scoped_refptr<storage::ShareableFileReference> file_reference =
storage::ShareableFileReference::GetOrCreate(storage::ScopedFile(
@@ -133,7 +133,7 @@ void AsyncFileUtil::CreateOrOpen(
const storage::FileSystemURL& url,
int file_flags,
const CreateOrOpenCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -157,7 +157,7 @@ void AsyncFileUtil::EnsureFileExists(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const EnsureFileExistsCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -180,7 +180,7 @@ void AsyncFileUtil::CreateDirectory(
bool exclusive,
bool recursive,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -200,7 +200,7 @@ void AsyncFileUtil::GetFileInfo(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const GetFileInfoCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -220,7 +220,7 @@ void AsyncFileUtil::ReadDirectory(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const ReadDirectoryCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -242,7 +242,7 @@ void AsyncFileUtil::Touch(
const base::Time& last_access_time,
const base::Time& last_modified_time,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -263,7 +263,7 @@ void AsyncFileUtil::Truncate(
const storage::FileSystemURL& url,
int64 length,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -285,7 +285,7 @@ void AsyncFileUtil::CopyFileLocal(
CopyOrMoveOption option,
const CopyFileProgressCallback& progress_callback,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath src_path = util::ExtractDrivePathFromFileSystemUrl(src_url);
base::FilePath dest_path = util::ExtractDrivePathFromFileSystemUrl(dest_url);
@@ -317,7 +317,7 @@ void AsyncFileUtil::MoveFileLocal(
const storage::FileSystemURL& dest_url,
CopyOrMoveOption option,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath src_path = util::ExtractDrivePathFromFileSystemUrl(src_url);
base::FilePath dest_path = util::ExtractDrivePathFromFileSystemUrl(dest_url);
@@ -342,7 +342,7 @@ void AsyncFileUtil::CopyInForeignFile(
const base::FilePath& src_file_path,
const storage::FileSystemURL& dest_url,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath dest_path = util::ExtractDrivePathFromFileSystemUrl(dest_url);
if (dest_path.empty()) {
@@ -362,7 +362,7 @@ void AsyncFileUtil::DeleteFile(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -382,7 +382,7 @@ void AsyncFileUtil::DeleteDirectory(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -402,7 +402,7 @@ void AsyncFileUtil::DeleteRecursively(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const StatusCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {
@@ -422,7 +422,7 @@ void AsyncFileUtil::CreateSnapshotFile(
scoped_ptr<storage::FileSystemOperationContext> context,
const storage::FileSystemURL& url,
const CreateSnapshotFileCallback& callback) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
base::FilePath file_path = util::ExtractDrivePathFromFileSystemUrl(url);
if (file_path.empty()) {

Powered by Google App Engine
This is Rietveld 408576698