chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc - Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc

Issue 1036723003: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/chromeos/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/system_logs/command_line_log_source.cc ('k') | chrome/browser/chromeos/system_logs/touch_log_source_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc

diff --git a/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc b/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc

index 47bc739df8e78e033c94933e03f820e6dfffc3de..030536d4ef5de8f1ab2231a119beaa7a9ebfd468 100644

--- a/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc

+++ b/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc

@@ -119,7 +119,7 @@ void PackEventLog(system_logs::SystemLogsResponse* response,

void OnEventLogCollected(scoped_ptr<system_logs::SystemLogsResponse> response,

const system_logs::SysLogsSourceCallback& callback,

scoped_ptr<std::vector<base::FilePath>> log_paths) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// We cannot eliminate these temporaries and inline these closures because the

// compiler may call release() before get().

@@ -139,7 +139,7 @@ void OnEventLogCollected(scoped_ptr<system_logs::SystemLogsResponse> response,

void OnStatusLogCollected(scoped_ptr<system_logs::SystemLogsResponse> response,

const system_logs::SysLogsSourceCallback& callback,

scoped_ptr<std::string> log) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

(*response)[kDeviceStatusLogDataKey] = *log;

// Collect touch event logs.

@@ -167,7 +167,7 @@ void CollectTouchHudDebugLog(system_logs::SystemLogsResponse* response) {

namespace system_logs {

void TouchLogSource::Fetch(const SysLogsSourceCallback& callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(!callback.is_null());

scoped_ptr<SystemLogsResponse> response(new SystemLogsResponse);