Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 8 months ago
CC:
chromium-reviews, michaeln, feature-media-reviews_chromium.org, kinuko+watch, darin-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

RefCounted types should not have public destructors, webkit/ BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134449

Patch Set 1 #

Patch Set 2 : Implementation ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -208 lines) Patch
M webkit/appcache/appcache_database_unittest.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_host_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 1 1 chunk +13 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_service.h View 1 chunk +4 lines, -1 line 0 comments Download
M webkit/appcache/appcache_storage_impl.cc View 1 17 chunks +99 lines, -27 lines 0 comments Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_storage_unittest.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M webkit/appcache/view_appcache_internals_job.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/blob/blob_url_request_job.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/database/database_quota_client.cc View 1 8 chunks +22 lines, -3 lines 0 comments Download
M webkit/database/database_quota_client_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/database/database_tracker_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/database/databases_table_unittest.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M webkit/database/quota_table_unittest.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_context.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_context.cc View 1 3 chunks +10 lines, -11 lines 0 comments Download
M webkit/fileapi/file_system_operation_unittest.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_operation_write_unittest.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_quota_client.cc View 1 6 chunks +12 lines, -5 lines 0 comments Download
M webkit/fileapi/file_writer_delegate.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M webkit/glue/resource_loader_bridge.cc View 1 3 chunks +7 lines, -14 lines 0 comments Download
M webkit/media/buffered_data_source.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/media/buffered_data_source_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_lib_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/plugin_stream_url.h View 1 2 chunks +3 lines, -5 lines 0 comments Download
M webkit/plugins/npapi/plugin_stream_url.cc View 1 3 chunks +12 lines, -12 lines 0 comments Download
M webkit/quota/mock_quota_manager.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/quota/mock_quota_manager.cc View 1 4 chunks +12 lines, -4 lines 0 comments Download
M webkit/quota/mock_special_storage_policy.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webkit/quota/mock_special_storage_policy.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/quota/quota_database_unittest.cc View 1 1 chunk +6 lines, -3 lines 0 comments Download
M webkit/quota/quota_manager.h View 1 4 chunks +13 lines, -10 lines 0 comments Download
M webkit/quota/quota_manager.cc View 1 23 chunks +84 lines, -21 lines 0 comments Download
M webkit/support/test_webmessageportchannel.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M webkit/support/test_webmessageportchannel.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 8 chunks +18 lines, -16 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webblobregistry_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_webblobregistry_impl.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
tony: PTAL
8 years, 8 months ago (2012-04-13 09:32:57 UTC) #1
scherkus (not reviewing)
(webkit/media = lgtm, but tony need to look at the rest)
8 years, 8 months ago (2012-04-13 18:13:11 UTC) #2
tony
LGTM
8 years, 8 months ago (2012-04-26 18:41:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10066044/5001
8 years, 8 months ago (2012-04-28 05:31:35 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 07:04:39 UTC) #5 
Change committed as 134449

Powered by Google App Engine
This is Rietveld 408576698