RefCounted types should not have public destructors, webkit/

webkit/fileapi/file_system_quota_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_quota_client.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/file_path.h"
@@ skipping 23 matching lines @@
       FileSystemType type)
       : QuotaThreadTask(quota_client, file_message_loop),
         quota_client_(quota_client),
         origin_url_(origin_url),
         type_(type),
         fs_usage_(0) {
     DCHECK(quota_client_);
     file_system_context_ = quota_client_->file_system_context_;
   }
 
+ protected:
   virtual ~GetOriginUsageTask() {}
 
- protected:
+  // QuotaThreadTask:
   virtual void RunOnTargetThread() OVERRIDE {
     FileSystemQuotaUtil* quota_util = file_system_context_->GetQuotaUtil(type_);
     if (quota_util)
       fs_usage_ = quota_util->GetOriginUsageOnFileThread(origin_url_, type_);
   }
 
   virtual void Completed() OVERRIDE {
     quota_client_->DidGetOriginUsage(type_, origin_url_, fs_usage_);
   }
 
   FileSystemQuotaClient* quota_client_;
   scoped_refptr<FileSystemContext> file_system_context_;
   GURL origin_url_;
   FileSystemType type_;
   int64 fs_usage_;
 };
 
 class FileSystemQuotaClient::GetOriginsForTypeTask : public QuotaThreadTask {
  public:
   GetOriginsForTypeTask(
       FileSystemQuotaClient* quota_client,
       scoped_refptr<MessageLoopProxy> file_message_loop,
       FileSystemType type)
       : QuotaThreadTask(quota_client, file_message_loop),
         quota_client_(quota_client),
         type_(type) {
     DCHECK(quota_client_);
     file_system_context_ = quota_client_->file_system_context_;
   }
+
+ protected:
   virtual ~GetOriginsForTypeTask() {}
 
- protected:
+  // QuotaThreadTask:
   virtual void RunOnTargetThread() OVERRIDE {
     FileSystemQuotaUtil* quota_util = file_system_context_->GetQuotaUtil(type_);
     if (quota_util)
       quota_util->GetOriginsForTypeOnFileThread(type_, &origins_);
   }
 
   virtual void Completed() OVERRIDE {
     quota_client_->DidGetOriginsForType(type_, origins_);
   }
 
@@ skipping 11 matching lines @@
       scoped_refptr<MessageLoopProxy> file_message_loop,
       FileSystemType type,
       const std::string& host)
       : QuotaThreadTask(quota_client, file_message_loop),
         quota_client_(quota_client),
         type_(type),
         host_(host) {
     DCHECK(quota_client_);
     file_system_context_ = quota_client_->file_system_context_;
   }
+
+ protected:
   virtual ~GetOriginsForHostTask() {}
 
- protected:
+  // QuotaThreadTask:
   virtual void RunOnTargetThread() OVERRIDE {
     FileSystemQuotaUtil* quota_util = file_system_context_->GetQuotaUtil(type_);
     if (quota_util)
       quota_util->GetOriginsForHostOnFileThread(type_, host_, &origins_);
   }
 
   virtual void Completed() OVERRIDE {
     quota_client_->DidGetOriginsForHost(std::make_pair(type_, host_), origins_);
   }
 
@@ skipping 15 matching lines @@
       FileSystemType type,
       const DeletionCallback& callback)
       : QuotaThreadTask(quota_client, file_message_loop),
         file_system_context_(quota_client->file_system_context_),
         origin_(origin),
         type_(type),
         status_(quota::kQuotaStatusUnknown),
         callback_(callback) {
   }
 
+ protected:
   virtual ~DeleteOriginTask() {}
 
+  // QuotaThreadTask:
   virtual void RunOnTargetThread() OVERRIDE {
     if (file_system_context_->DeleteDataForOriginAndTypeOnFileThread(
             origin_, type_))
       status_ = quota::kQuotaStatusOk;
     else
       status_ = quota::kQuotaErrorInvalidModification;
   }
 
   virtual void Completed() OVERRIDE {
     callback_.Run(status_);
   }
+
  private:
   FileSystemContext* file_system_context_;
   GURL origin_;
   FileSystemType type_;
   quota::QuotaStatusCode status_;
   DeletionCallback callback_;
 };
 
 FileSystemQuotaClient::FileSystemQuotaClient(
     scoped_refptr<base::MessageLoopProxy> file_message_loop,
     FileSystemContext* file_system_context,
     bool is_incognito)
     : file_message_loop_(file_message_loop),
       file_system_context_(file_system_context),
       is_incognito_(is_incognito) {
   DCHECK(file_message_loop);
 }
 
-FileSystemQuotaClient::~FileSystemQuotaClient() {
-}
+FileSystemQuotaClient::~FileSystemQuotaClient() {}
 
 quota::QuotaClient::ID FileSystemQuotaClient::id() const {
   return quota::QuotaClient::kFileSystem;
 }
 
 void FileSystemQuotaClient::OnQuotaManagerDestroyed() {
   delete this;
 }
 
 void FileSystemQuotaClient::GetOriginUsage(
@@ skipping 93 matching lines @@
 }
 
 void FileSystemQuotaClient::DidGetOriginsForHost(
     const TypeAndHostOrOrigin& type_and_host, const std::set<GURL>& origins) {
   DCHECK(pending_origins_for_host_callbacks_.HasCallbacks(type_and_host));
   pending_origins_for_host_callbacks_.Run(type_and_host, origins,
       FileSystemTypeToQuotaStorageType(type_and_host.first));
 }
 
 }  // namespace fileapi