RefCounted types should not have public destructors, webkit/

webkit/appcache/appcache_url_request_job.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_URL_REQUEST_JOB_H_
 #define WEBKIT_APPCACHE_APPCACHE_URL_REQUEST_JOB_H_
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
 #include "net/http/http_byte_range.h"
 #include "net/url_request/url_request_job.h"
 #include "webkit/appcache/appcache_entry.h"
 #include "webkit/appcache/appcache_export.h"
 #include "webkit/appcache/appcache_response.h"
 #include "webkit/appcache/appcache_storage.h"
 
 namespace appcache {
 
 // A net::URLRequestJob derivative that knows how to return a response stored
 // in the appcache.
 class APPCACHE_EXPORT AppCacheURLRequestJob : public net::URLRequestJob,
                                               public AppCacheStorage::Delegate {
  public:
   AppCacheURLRequestJob(net::URLRequest* request, AppCacheStorage* storage);
-  virtual ~AppCacheURLRequestJob();
 
   // Informs the job of what response it should deliver. Only one of these
   // methods should be called, and only once per job. A job will sit idle and
   // wait indefinitely until one of the deliver methods is called.
   void DeliverAppCachedResponse(const GURL& manifest_url, int64 group_id,
                                 int64 cache_id, const AppCacheEntry& entry,
                                 bool is_fallback);
   void DeliverNetworkResponse();
   void DeliverErrorResponse();
 
@@ skipping 33 matching lines @@
   // Returns true if the job has been killed.
   bool has_been_killed() const {
     return has_been_killed_;
   }
 
   // Returns true if the cache entry was not found in the disk cache.
   bool cache_entry_not_found() const {
     return cache_entry_not_found_;
   }
 
+ protected:
+  virtual ~AppCacheURLRequestJob();
+
  private:
   friend class AppCacheRequestHandlerTest;
   friend class AppCacheURLRequestJobTest;
 
   enum DeliveryType {
     AWAITING_DELIVERY_ORDERS,
     APPCACHED_DELIVERY,
     NETWORK_DELIVERY,
     ERROR_DELIVERY
   };
@@ skipping 48 matching lines @@
   scoped_refptr<AppCacheResponseInfo> info_;
   net::HttpByteRange range_requested_;
   scoped_ptr<net::HttpResponseInfo> range_response_info_;
   scoped_ptr<AppCacheResponseReader> reader_;
   base::WeakPtrFactory<AppCacheURLRequestJob> weak_factory_;
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_REQUEST_HANDLER_H_