webkit/plugins/npapi/plugin_lib_unittest.cc - Issue 10066044: RefCounted types should not have public destructors, webkit/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/plugin_lib_unittest.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/npapi/plugin_lib_unittest.cc

diff --git a/webkit/plugins/npapi/plugin_lib_unittest.cc b/webkit/plugins/npapi/plugin_lib_unittest.cc

index 516c24bc58a566174325e56ccd8192b89b344676..d62174d3015eabdf5f700f1954e93e192504df50 100644

--- a/webkit/plugins/npapi/plugin_lib_unittest.cc

+++ b/webkit/plugins/npapi/plugin_lib_unittest.cc

@@ -17,9 +17,11 @@ namespace npapi {

// variable, we can get a crash if no plugin libs were marked as always loaded.

class PluginLibTest : public PluginLib {

public:

- PluginLibTest() : PluginLib(WebPluginInfo(), NULL) {

- }

+ PluginLibTest() : PluginLib(WebPluginInfo(), NULL) {}

using PluginLib::Unload;

+ protected:

+ virtual ~PluginLibTest() {}

};

TEST(PluginLibLoading, UnloadAllPlugins) {