Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: webkit/glue/resource_loader_bridge.h

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « webkit/fileapi/obfuscated_file_util.cc ('k') | webkit/glue/resource_loader_bridge.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The intent of this file is to provide a type-neutral abstraction between 5 // The intent of this file is to provide a type-neutral abstraction between
6 // Chrome and WebKit for resource loading. This pure-virtual interface is 6 // Chrome and WebKit for resource loading. This pure-virtual interface is
7 // implemented by the embedder. 7 // implemented by the embedder.
8 // 8 //
9 // One of these objects will be created by WebKit for each request. WebKit 9 // One of these objects will be created by WebKit for each request. WebKit
10 // will own the pointer to the bridge, and will delete it when the request is 10 // will own the pointer to the bridge, and will delete it when the request is
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 // The time at which receiving HTTP headers ended. For non-HTTP requests 102 // The time at which receiving HTTP headers ended. For non-HTTP requests
103 // this is 0. 103 // this is 0.
104 int32 receive_headers_end; 104 int32 receive_headers_end;
105 }; 105 };
106 106
107 struct ResourceDevToolsInfo : base::RefCounted<ResourceDevToolsInfo> { 107 struct ResourceDevToolsInfo : base::RefCounted<ResourceDevToolsInfo> {
108 typedef std::vector<std::pair<std::string, std::string> > 108 typedef std::vector<std::pair<std::string, std::string> >
109 HeadersVector; 109 HeadersVector;
110 110
111 WEBKIT_GLUE_EXPORT ResourceDevToolsInfo(); 111 WEBKIT_GLUE_EXPORT ResourceDevToolsInfo();
112 WEBKIT_GLUE_EXPORT ~ResourceDevToolsInfo();
113 112
114 int32 http_status_code; 113 int32 http_status_code;
115 std::string http_status_text; 114 std::string http_status_text;
116 HeadersVector request_headers; 115 HeadersVector request_headers;
117 HeadersVector response_headers; 116 HeadersVector response_headers;
118 std::string request_headers_text; 117 std::string request_headers_text;
119 std::string response_headers_text; 118 std::string response_headers_text;
119
120 private:
121 friend class base::RefCounted<ResourceDevToolsInfo>;
122 WEBKIT_GLUE_EXPORT ~ResourceDevToolsInfo();
120 }; 123 };
121 124
122 struct ResourceResponseInfo { 125 struct ResourceResponseInfo {
123 WEBKIT_GLUE_EXPORT ResourceResponseInfo(); 126 WEBKIT_GLUE_EXPORT ResourceResponseInfo();
124 WEBKIT_GLUE_EXPORT ~ResourceResponseInfo(); 127 WEBKIT_GLUE_EXPORT ~ResourceResponseInfo();
125 128
126 // The time at which the request was made that resulted in this response. 129 // The time at which the request was made that resulted in this response.
127 // For cached responses, this time could be "far" in the past. 130 // For cached responses, this time could be "far" in the past.
128 base::Time request_time; 131 base::Time request_time;
129 132
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 // methods may be called to construct the body of the request. 409 // methods may be called to construct the body of the request.
407 WEBKIT_GLUE_EXPORT ResourceLoaderBridge(); 410 WEBKIT_GLUE_EXPORT ResourceLoaderBridge();
408 411
409 private: 412 private:
410 DISALLOW_COPY_AND_ASSIGN(ResourceLoaderBridge); 413 DISALLOW_COPY_AND_ASSIGN(ResourceLoaderBridge);
411 }; 414 };
412 415
413 } // namespace webkit_glue 416 } // namespace webkit_glue
414 417
415 #endif // WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_ 418 #endif // WEBKIT_GLUE_RESOURCE_LOADER_BRIDGE_H_
OLDNEW
« no previous file with comments | « webkit/fileapi/obfuscated_file_util.cc ('k') | webkit/glue/resource_loader_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698