Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1735)

Unified Diff: webkit/quota/mock_quota_manager.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/quota/mock_quota_manager.h ('k') | webkit/quota/mock_special_storage_policy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/quota/mock_quota_manager.cc
diff --git a/webkit/quota/mock_quota_manager.cc b/webkit/quota/mock_quota_manager.cc
index bac3fcc02a56b034b44c0f7d39707d1dc5a6fe54..595c43a56d60c3536f748ee131bfa500ce613a26 100644
--- a/webkit/quota/mock_quota_manager.cc
+++ b/webkit/quota/mock_quota_manager.cc
@@ -27,9 +27,13 @@ class MockQuotaManager::GetModifiedSinceTask : public QuotaThreadTask {
: QuotaThreadTask(manager, manager->io_thread_),
origins_(origins),
type_(type),
- callback_(callback) {}
+ callback_(callback) {
+ }
protected:
+ virtual ~GetModifiedSinceTask() {}
+
+ // QuotaThreadTask:
virtual void RunOnTargetThread() OVERRIDE {}
virtual void Completed() OVERRIDE {
@@ -53,9 +57,13 @@ class MockQuotaManager::DeleteOriginDataTask : public QuotaThreadTask {
DeleteOriginDataTask(MockQuotaManager* manager,
const StatusCallback& callback)
: QuotaThreadTask(manager, manager->io_thread_),
- callback_(callback) {}
+ callback_(callback) {
+ }
protected:
+ virtual ~DeleteOriginDataTask() {}
+
+ // QuotaThreadTask:
virtual void RunOnTargetThread() OVERRIDE {}
virtual void Completed() OVERRIDE {
@@ -95,8 +103,6 @@ MockQuotaManager::MockQuotaManager(
special_storage_policy) {
}
-MockQuotaManager::~MockQuotaManager() {}
-
bool MockQuotaManager::AddOrigin(
const GURL& origin,
StorageType type,
@@ -155,4 +161,6 @@ void MockQuotaManager::DeleteOriginData(
make_scoped_refptr(new DeleteOriginDataTask(this, callback))->Start();
}
+MockQuotaManager::~MockQuotaManager() {}
+
} // namespace quota
« no previous file with comments | « webkit/quota/mock_quota_manager.h ('k') | webkit/quota/mock_special_storage_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698