RefCounted types should not have public destructors, webkit/

webkit/fileapi/file_system_operation_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_operation.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
@@ skipping 44 matching lines @@
       accessed_(0) {}
 
   virtual void GetUsageAndQuota(
       const GURL& origin, quota::StorageType type,
       const GetUsageAndQuotaCallback& callback) OVERRIDE {
     EXPECT_EQ(origin_, origin);
     EXPECT_EQ(type_, type);
     callback.Run(quota::kQuotaStatusOk, usage_, quota_);
   }
 
+ protected:
+  virtual ~MockQuotaManager() {}
+
  private:
   friend class MockQuotaManagerProxy;
+
   void SetQuota(const GURL& origin, StorageType type, int64 quota) {
     EXPECT_EQ(origin_, origin);
     EXPECT_EQ(type_, type);
     quota_ = quota;
   }
 
   void RecordStorageAccessed(const GURL& origin, StorageType type) {
     EXPECT_EQ(origin_, origin);
     EXPECT_EQ(type_, type);
     ++accessed_;
@@ skipping 13 matching lines @@
 };
 
 class MockQuotaManagerProxy : public QuotaManagerProxy {
  public:
   explicit MockQuotaManagerProxy(QuotaManager* quota_manager)
       : QuotaManagerProxy(quota_manager,
                           base::MessageLoopProxy::current()),
         registered_client_(NULL) {
   }
 
-  virtual ~MockQuotaManagerProxy() {
-    EXPECT_FALSE(registered_client_);
-  }
-
   virtual void RegisterClient(QuotaClient* client) OVERRIDE {
     EXPECT_FALSE(registered_client_);
     registered_client_ = client;
   }
 
   void SimulateQuotaManagerDestroyed() {
     if (registered_client_) {
       // We cannot call this in the destructor as the client (indirectly)
       // holds a refptr of the proxy.
       registered_client_->OnQuotaManagerDestroyed();
@@ skipping 19 matching lines @@
   }
 
   int storage_accessed_count() const {
     return mock_manager()->accessed_;
   }
 
   void SetQuota(const GURL& origin, StorageType type, int64 quota) {
     mock_manager()->SetQuota(origin, type, quota);
   }
 
+ protected:
+  virtual ~MockQuotaManagerProxy() {
+    EXPECT_FALSE(registered_client_);
+  }
+
  private:
   MockQuotaManager* mock_manager() const {
     return static_cast<MockQuotaManager*>(quota_manager());
   }
+
   QuotaClient* registered_client_;
 };
 
 FilePath ASCIIToFilePath(const std::string& str) {
   return FilePath().AppendASCII(str);
 }
 
 }  // namespace (anonymous)
 
 // Test class for FileSystemOperation.
@@ skipping 978 matching lines @@
   EXPECT_EQ(base::PLATFORM_FILE_OK, status());
   EXPECT_FALSE(info().is_directory);
   EXPECT_EQ(PlatformPath(file_path), path());
 
   // The FileSystemOpration implementation does not create a
   // shareable file reference.
   EXPECT_EQ(NULL, shareable_file_ref());
 }
 
 }  // namespace fileapi