Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: webkit/quota/quota_manager.h

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/quota/quota_database_unittest.cc ('k') | webkit/quota/quota_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/quota/quota_manager.h
diff --git a/webkit/quota/quota_manager.h b/webkit/quota/quota_manager.h
index 65361521ac9e697bdd0253d28228ec23037e7ad4..b86cbfde7b305782d852af4cfef596a3920de1cc 100644
--- a/webkit/quota/quota_manager.h
+++ b/webkit/quota/quota_manager.h
@@ -21,6 +21,7 @@
#include "base/memory/weak_ptr.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "base/sequenced_task_runner_helpers.h"
#include "webkit/quota/quota_database.h"
#include "webkit/quota/quota_client.h"
#include "webkit/quota/quota_task.h"
@@ -109,8 +110,6 @@ class QuotaManager : public QuotaTaskObserver,
base::MessageLoopProxy* db_thread,
SpecialStoragePolicy* special_storage_policy);
- virtual ~QuotaManager();
-
// Returns a proxy object that can be used on any thread.
QuotaManagerProxy* proxy() { return proxy_.get(); }
@@ -204,7 +203,19 @@ class QuotaManager : public QuotaTaskObserver,
static const int kEvictionIntervalInMilliSeconds;
+ protected:
+ virtual ~QuotaManager();
+
private:
+ friend class base::DeleteHelper<QuotaManager>;
+ friend class MockQuotaManager;
+ friend class MockStorageClient;
+ friend class quota_internals::QuotaInternalsProxy;
+ friend class QuotaManagerProxy;
+ friend class QuotaManagerTest;
+ friend class QuotaTemporaryStorageEvictor;
+ friend struct QuotaManagerDeleter;
+
class DatabaseTaskBase;
class InitializeTask;
class UpdateTemporaryQuotaOverrideTask;
@@ -256,14 +267,6 @@ class QuotaManager : public QuotaTaskObserver,
typedef QuotaEvictionHandler::GetUsageAndQuotaForEvictionCallback
UsageAndQuotaDispatcherCallback;
- friend class quota_internals::QuotaInternalsProxy;
- friend struct QuotaManagerDeleter;
- friend class MockStorageClient;
- friend class QuotaManagerProxy;
- friend class QuotaManagerTest;
- friend class QuotaTemporaryStorageEvictor;
- friend class MockQuotaManager;
-
// This initialization method is lazily called on the IO thread
// when the first quota manager API is called.
// Initialize must be called after all quota clients are added to the
« no previous file with comments | « webkit/quota/quota_database_unittest.cc ('k') | webkit/quota/quota_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698