Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: webkit/appcache/appcache_request_handler_unittest.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_host_unittest.cc ('k') | webkit/appcache/appcache_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_request_handler_unittest.cc
diff --git a/webkit/appcache/appcache_request_handler_unittest.cc b/webkit/appcache/appcache_request_handler_unittest.cc
index 37b7bd1efab6f1c033f55b25243c339e8544c851..f91af0f00fe3d90a5e0a01e897cce58505e03d24 100644
--- a/webkit/appcache/appcache_request_handler_unittest.cc
+++ b/webkit/appcache/appcache_request_handler_unittest.cc
@@ -72,28 +72,34 @@ class AppCacheRequestHandlerTest : public testing::Test {
class MockURLRequestJob : public net::URLRequestJob {
public:
- MockURLRequestJob(
- net::URLRequest* request, int response_code)
+ MockURLRequestJob(net::URLRequest* request,
+ int response_code)
: net::URLRequestJob(request),
response_code_(response_code),
has_response_info_(false) {}
- MockURLRequestJob(
- net::URLRequest* request, const net::HttpResponseInfo& info)
+ MockURLRequestJob(net::URLRequest* request,
+ const net::HttpResponseInfo& info)
: net::URLRequestJob(request),
response_code_(info.headers->response_code()),
has_response_info_(true),
response_info_(info) {}
- virtual void Start() {
+
+ protected:
+ virtual ~MockURLRequestJob() {}
+ virtual void Start() OVERRIDE {
NotifyHeadersComplete();
}
- virtual int GetResponseCode() const {
+ virtual int GetResponseCode() const OVERRIDE {
return response_code_;
}
- virtual void GetResponseInfo(net::HttpResponseInfo* info) {
+ virtual void GetResponseInfo(
+ net::HttpResponseInfo* info) OVERRIDE {
if (!has_response_info_)
return;
*info = response_info_;
}
+
+ private:
int response_code_;
bool has_response_info_;
net::HttpResponseInfo response_info_;
« no previous file with comments | « webkit/appcache/appcache_host_unittest.cc ('k') | webkit/appcache/appcache_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698