RefCounted types should not have public destructors, webkit/

webkit/appcache/view_appcache_internals_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 
 #include "webkit/appcache/view_appcache_internals_job.h"
 
 #include "base/base64.h"
@@ skipping 294 matching lines @@
   GURL::Replacements replacements;
   replacements.ClearQuery();
   return url.ReplaceComponents(replacements);
 }
 
 // Simple base class for the job subclasses defined here.
 class BaseInternalsJob : public net::URLRequestSimpleJob {
  protected:
   BaseInternalsJob(net::URLRequest* request, AppCacheService* service)
       : URLRequestSimpleJob(request), appcache_service_(service) {}
+  virtual ~BaseInternalsJob() {}
 
   AppCacheService* appcache_service_;
 };
 
 // Job that lists all appcaches in the system.
 class MainPageJob : public BaseInternalsJob {
  public:
   MainPageJob(net::URLRequest* request, AppCacheService* service)
       : BaseInternalsJob(request, service),
         ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)) {
@@ skipping 62 matching lines @@
                        std::string* charset,
                        std::string* data) const {
     return true;  // IsRedirectResponse induces a redirect.
   }
 
   virtual bool IsRedirectResponse(GURL* location, int* http_status_code) {
     *location = ClearQuery(request_->url());
     *http_status_code = 307;
     return true;
   }
+
+ protected:
+  virtual ~RedirectToMainPageJob() {}
 };
 
 // Job that removes an appcache and then redirects back to the main page.
 class RemoveAppCacheJob : public RedirectToMainPageJob {
  public:
   RemoveAppCacheJob(
       net::URLRequest* request, AppCacheService* service,
       const GURL& manifest_url)
       : RedirectToMainPageJob(request, service),
         manifest_url_(manifest_url),
@@ skipping 208 matching lines @@
     return new ViewEntryJob(request, service,
                             DecodeBase64URL(tokens[0]),  // manifest url
                             DecodeBase64URL(tokens[1]),  // entry url
                             response_id, group_id);
   }
 
   return new RedirectToMainPageJob(request, service);
 }
 
 }  // namespace appcache