Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: webkit/appcache/appcache_url_request_job.h

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_update_job_unittest.cc ('k') | webkit/appcache/appcache_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_url_request_job.h
diff --git a/webkit/appcache/appcache_url_request_job.h b/webkit/appcache/appcache_url_request_job.h
index 25b0cf68a76dfe21a09d5c7bc7c1a6831780f608..c60426c94dac7373cbd2e29b768e1eb862ff207b 100644
--- a/webkit/appcache/appcache_url_request_job.h
+++ b/webkit/appcache/appcache_url_request_job.h
@@ -23,7 +23,6 @@ class APPCACHE_EXPORT AppCacheURLRequestJob : public net::URLRequestJob,
public AppCacheStorage::Delegate {
public:
AppCacheURLRequestJob(net::URLRequest* request, AppCacheStorage* storage);
- virtual ~AppCacheURLRequestJob();
// Informs the job of what response it should deliver. Only one of these
// methods should be called, and only once per job. A job will sit idle and
@@ -77,6 +76,9 @@ class APPCACHE_EXPORT AppCacheURLRequestJob : public net::URLRequestJob,
return cache_entry_not_found_;
}
+ protected:
+ virtual ~AppCacheURLRequestJob();
+
private:
friend class AppCacheRequestHandlerTest;
friend class AppCacheURLRequestJobTest;
« no previous file with comments | « webkit/appcache/appcache_update_job_unittest.cc ('k') | webkit/appcache/appcache_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698