webkit/appcache/appcache_service.h - Issue 10066044: RefCounted types should not have public destructors, webkit/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/appcache/appcache_service.h

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/appcache/appcache_service.h

diff --git a/webkit/appcache/appcache_service.h b/webkit/appcache/appcache_service.h

index f1f8c0ba74c8af680c884d4c6cbd4a588c9daf55..6a5cea1e04ab338757a613fe07e085b0fa72b996 100644

--- a/webkit/appcache/appcache_service.h

+++ b/webkit/appcache/appcache_service.h

@@ -43,9 +43,12 @@ class AppCachePolicy;

struct APPCACHE_EXPORT AppCacheInfoCollection

: public base::RefCountedThreadSafe<AppCacheInfoCollection> {

AppCacheInfoCollection();

- virtual ~AppCacheInfoCollection();

std::map<GURL, AppCacheInfoVector> infos_by_origin;

+ private:

+ friend class base::RefCountedThreadSafe<AppCacheInfoCollection>;

+ virtual ~AppCacheInfoCollection();

};

// Class that manages the application cache service. Sends notifications