RefCounted types should not have public destructors, webkit/

webkit/fileapi/file_system_operation_write_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit)
 // rather than as part of test_shell_tests because they rely on being able
 // to instantiate a MessageLoop of type TYPE_IO.  test_shell_tests uses
 // TYPE_UI, which URLRequest doesn't allow.
 //
 
@@ skipping 39 matching lines @@
 
   virtual void GetUsageAndQuota(
       const GURL& origin, quota::StorageType type,
       const GetUsageAndQuotaCallback& callback) OVERRIDE {
     callback.Run(quota::kQuotaStatusOk, usage_, quota_);
   }
 
   void set_usage(int64 usage) { usage_ = usage; }
   void set_quota(int64 quota) { quota_ = quota; }
 
+ protected:
+  virtual ~MockQuotaManager() {}
+
  private:
   int64 usage_;
   int64 quota_;
 };
 
-}  // namespace (anonymous)
+}  // namespace
 
 class FileSystemOperationWriteTest
     : public testing::Test,
       public base::SupportsWeakPtr<FileSystemOperationWriteTest> {
  public:
   FileSystemOperationWriteTest()
       : local_file_util_(new LocalFileUtil(QuotaFileUtil::CreateDefault())),
         loop_(MessageLoop::TYPE_IO),
         status_(base::PLATFORM_FILE_OK),
         cancel_status_(base::PLATFORM_FILE_ERROR_FAILED),
@@ skipping 68 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(FileSystemOperationWriteTest);
 };
 
 namespace {
 
 class TestURLRequestContext : public net::URLRequestContext {
  public:
   TestURLRequestContext()
       : blob_storage_controller_(new webkit_blob::BlobStorageController) {}
 
-  virtual ~TestURLRequestContext() {}
-
   webkit_blob::BlobStorageController* blob_storage_controller() const {
     return blob_storage_controller_.get();
   }
 
+ protected:
+  virtual ~TestURLRequestContext() {}
+
  private:
   scoped_ptr<webkit_blob::BlobStorageController> blob_storage_controller_;
 };
 
 static net::URLRequestJob* BlobURLRequestJobFactory(net::URLRequest* request,
                                                     const std::string& scheme) {
   webkit_blob::BlobStorageController* blob_storage_controller =
       static_cast<const TestURLRequestContext*>(request->context())->
           blob_storage_controller();
   return new webkit_blob::BlobURLRequestJob(
@@ skipping 213 matching lines @@
   // so nothing should have happen.
   EXPECT_EQ(0, bytes_written());
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_ABORT, status());
   EXPECT_EQ(base::PLATFORM_FILE_OK, cancel_status());
   EXPECT_TRUE(complete());
 }
 
 // TODO(ericu,dmikurube): Add more tests for Cancel.
 
 }  // namespace fileapi