RefCounted types should not have public destructors, webkit/

webkit/database/database_quota_client_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
@@ skipping 13 matching lines @@
 
 // Mock tracker class the mocks up those methods of the tracker
 // that are used by the QuotaClient.
 class MockDatabaseTracker : public DatabaseTracker {
  public:
   MockDatabaseTracker()
       : DatabaseTracker(FilePath(), false, NULL, NULL, NULL),
         delete_called_count_(0),
         async_delete_(false) {}
 
-  virtual ~MockDatabaseTracker() {}
-
   virtual bool GetOriginInfo(
       const string16& origin_identifier,
       OriginInfo* info) OVERRIDE {
     std::map<GURL, MockOriginInfo>::const_iterator found =
         mock_origin_infos_.find(
             DatabaseUtil::GetOriginFromIdentifier(origin_identifier));
     if (found == mock_origin_infos_.end())
       return false;
     *info = OriginInfo(found->second);
     return true;
@@ skipping 42 matching lines @@
   void AddMockDatabase(const GURL& origin,  const char* name, int size) {
     MockOriginInfo& info = mock_origin_infos_[origin];
     info.set_origin(DatabaseUtil::GetOriginIdentifier(origin));
     info.AddMockDatabase(ASCIIToUTF16(name), size);
   }
 
   int delete_called_count() { return delete_called_count_; }
   bool async_delete() { return async_delete_; }
   void set_async_delete(bool async) { async_delete_ = async; }
 
+ protected:
+  virtual ~MockDatabaseTracker() {}
+
  private:
   class MockOriginInfo : public OriginInfo {
    public:
     void set_origin(const string16& origin_id) {
       origin_ = origin_id;
     }
 
     void AddMockDatabase(const string16& name, int size) {
       EXPECT_TRUE(database_info_.find(name) == database_info_.end());
       database_info_[name].first = size;
@@ skipping 172 matching lines @@
   mock_tracker()->set_async_delete(false);
   EXPECT_TRUE(DeleteOriginData(&client, kTemp, kOriginA));
   EXPECT_EQ(1, mock_tracker()->delete_called_count());
 
   mock_tracker()->set_async_delete(true);
   EXPECT_TRUE(DeleteOriginData(&client, kTemp, kOriginA));
   EXPECT_EQ(2, mock_tracker()->delete_called_count());
 }
 
 }  // namespace webkit_database