Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: webkit/fileapi/file_system_quota_client.cc

Issue 10066044: RefCounted types should not have public destructors, webkit/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/fileapi/file_system_operation_write_unittest.cc ('k') | webkit/fileapi/file_writer_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/file_system_quota_client.cc
diff --git a/webkit/fileapi/file_system_quota_client.cc b/webkit/fileapi/file_system_quota_client.cc
index bb86fd99a2faf4df90f52bf3d1ceeb4beb3c2aa9..d0a1ccc2ea9eadda0db429e6b20ecbcd339358eb 100644
--- a/webkit/fileapi/file_system_quota_client.cc
+++ b/webkit/fileapi/file_system_quota_client.cc
@@ -41,9 +41,10 @@ class FileSystemQuotaClient::GetOriginUsageTask : public QuotaThreadTask {
file_system_context_ = quota_client_->file_system_context_;
}
+ protected:
virtual ~GetOriginUsageTask() {}
- protected:
+ // QuotaThreadTask:
virtual void RunOnTargetThread() OVERRIDE {
FileSystemQuotaUtil* quota_util = file_system_context_->GetQuotaUtil(type_);
if (quota_util)
@@ -73,9 +74,11 @@ class FileSystemQuotaClient::GetOriginsForTypeTask : public QuotaThreadTask {
DCHECK(quota_client_);
file_system_context_ = quota_client_->file_system_context_;
}
- virtual ~GetOriginsForTypeTask() {}
protected:
+ virtual ~GetOriginsForTypeTask() {}
+
+ // QuotaThreadTask:
virtual void RunOnTargetThread() OVERRIDE {
FileSystemQuotaUtil* quota_util = file_system_context_->GetQuotaUtil(type_);
if (quota_util)
@@ -107,9 +110,11 @@ class FileSystemQuotaClient::GetOriginsForHostTask : public QuotaThreadTask {
DCHECK(quota_client_);
file_system_context_ = quota_client_->file_system_context_;
}
- virtual ~GetOriginsForHostTask() {}
protected:
+ virtual ~GetOriginsForHostTask() {}
+
+ // QuotaThreadTask:
virtual void RunOnTargetThread() OVERRIDE {
FileSystemQuotaUtil* quota_util = file_system_context_->GetQuotaUtil(type_);
if (quota_util)
@@ -145,8 +150,10 @@ class FileSystemQuotaClient::DeleteOriginTask
callback_(callback) {
}
+ protected:
virtual ~DeleteOriginTask() {}
+ // QuotaThreadTask:
virtual void RunOnTargetThread() OVERRIDE {
if (file_system_context_->DeleteDataForOriginAndTypeOnFileThread(
origin_, type_))
@@ -158,6 +165,7 @@ class FileSystemQuotaClient::DeleteOriginTask
virtual void Completed() OVERRIDE {
callback_.Run(status_);
}
+
private:
FileSystemContext* file_system_context_;
GURL origin_;
@@ -176,8 +184,7 @@ FileSystemQuotaClient::FileSystemQuotaClient(
DCHECK(file_message_loop);
}
-FileSystemQuotaClient::~FileSystemQuotaClient() {
-}
+FileSystemQuotaClient::~FileSystemQuotaClient() {}
quota::QuotaClient::ID FileSystemQuotaClient::id() const {
return quota::QuotaClient::kFileSystem;
« no previous file with comments | « webkit/fileapi/file_system_operation_write_unittest.cc ('k') | webkit/fileapi/file_writer_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698