RefCounted types should not have public destructors, webkit/

webkit/appcache/appcache_request_handler_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stack>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 54 matching lines @@
   // Subclasses to simulate particular responses so test cases can
   // exercise fallback code paths.
 
   class MockURLRequestDelegate : public net::URLRequest::Delegate {
     virtual void OnResponseStarted(net::URLRequest* request) {}
     virtual void OnReadCompleted(net::URLRequest* request, int bytes_read) {}
   };
 
   class MockURLRequestJob : public net::URLRequestJob {
    public:
-    MockURLRequestJob(
-        net::URLRequest* request, int response_code)
+    MockURLRequestJob(net::URLRequest* request,
+                      int response_code)
         : net::URLRequestJob(request),
           response_code_(response_code),
           has_response_info_(false) {}
-    MockURLRequestJob(
-        net::URLRequest* request, const net::HttpResponseInfo& info)
+    MockURLRequestJob(net::URLRequest* request,
+                      const net::HttpResponseInfo& info)
         : net::URLRequestJob(request),
           response_code_(info.headers->response_code()),
           has_response_info_(true),
           response_info_(info) {}
-    virtual void Start() {
+
+  protected:
+    virtual ~MockURLRequestJob() {}
+    virtual void Start() OVERRIDE {
       NotifyHeadersComplete();
     }
-    virtual int GetResponseCode() const {
+    virtual int GetResponseCode() const OVERRIDE {
       return response_code_;
     }
-    virtual void GetResponseInfo(net::HttpResponseInfo* info) {
+    virtual void GetResponseInfo(
+        net::HttpResponseInfo* info) OVERRIDE {
       if (!has_response_info_)
         return;
       *info = response_info_;
     }
+
+  private:
     int response_code_;
     bool has_response_info_;
     net::HttpResponseInfo response_info_;
   };
 
   class MockURLRequest : public net::URLRequest {
    public:
     explicit MockURLRequest(const GURL& url) : net::URLRequest(url, NULL) {}
 
     void SimulateResponseCode(int http_response_code) {
@@ skipping 781 matching lines @@
 
 TEST_F(AppCacheRequestHandlerTest, WorkerRequest) {
   RunTestOnIOThread(&AppCacheRequestHandlerTest::WorkerRequest);
 }
 
 TEST_F(AppCacheRequestHandlerTest, MainResource_Blocked) {
   RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Blocked);
 }
 
 }  // namespace appcache