RefCounted types should not have public destructors, webkit/

webkit/database/database_tracker_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop_proxy.h"
 #include "base/platform_file.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 76 matching lines @@
             observer->GetNotificationDatabaseSize());
 }
 
 class TestQuotaManagerProxy : public quota::QuotaManagerProxy {
  public:
   TestQuotaManagerProxy()
       : QuotaManagerProxy(NULL, NULL),
         registered_client_(NULL) {
   }
 
-  virtual ~TestQuotaManagerProxy() {
-    EXPECT_FALSE(registered_client_);
-  }
-
   virtual void RegisterClient(quota::QuotaClient* client) {
     EXPECT_FALSE(registered_client_);
     registered_client_ = client;
   }
 
   virtual void NotifyStorageAccessed(quota::QuotaClient::ID client_id,
                                      const GURL& origin,
                                      quota::StorageType type) {
     EXPECT_EQ(quota::QuotaClient::kDatabase, client_id);
     EXPECT_EQ(quota::kStorageTypeTemporary, type);
@@ skipping 35 matching lines @@
     modifications_.clear();
   }
 
   quota::QuotaClient* registered_client_;
 
   // Map from origin to count of access notifications.
   std::map<GURL, int> accesses_;
 
   // Map from origin to <count, sum of deltas>
   std::map<GURL, std::pair<int, int64> > modifications_;
+
+ protected:
+  virtual ~TestQuotaManagerProxy() {
+    EXPECT_FALSE(registered_client_);
+  }
 };
 
 
 bool EnsureFileOfSize(const FilePath& file_path, int64 length) {
   base::PlatformFileError error_code(base::PLATFORM_FILE_ERROR_FAILED);
   base::PlatformFile file =
       base::CreatePlatformFile(
           file_path,
           base::PLATFORM_FILE_OPEN_ALWAYS | base::PLATFORM_FILE_WRITE,
           NULL,
@@ skipping 776 matching lines @@
 
 TEST(DatabaseTrackerTest, EmptyDatabaseNameIsValid) {
   DatabaseTracker_TestHelper_Test::EmptyDatabaseNameIsValid();
 }
 
 TEST(DatabaseTrackerTest, HandleSqliteError) {
   DatabaseTracker_TestHelper_Test::HandleSqliteError();
 }
 
 }  // namespace webkit_database