Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed)

Created:
5 years, 10 months ago by bokan
Modified:
5 years, 10 months ago
CC:
dcheng, aandrey+blink_chromium.org, android-webview-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, Dmitry Titov, estade+watch_chromium.org, extensions-reviews_chromium.org, gunsch+watch_chromium.org, jam, jennb, jianli, jochen+watch_chromium.org, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, paulirish+reviews_chromium.org, penghuang+watch_chromium.org, pfeldman, rouslan+autofillwatch_chromium.org, James Su, tfarina, vsevik, yukishiino+watch_chromium.org, yurys, yusukes+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. These IPCs hold this param as a gfx::Rect and the RenderWidget and RenderView set the size. On the receiving end, the size is sometimes used so initial_pos was a misnomer. This is a mechanical rename, there should be no functional difference. TBR= BUG= Committed: https://crrev.com/107a47faa8f7e9c38cd0e7aeac74751b103df215 Cr-Commit-Position: refs/heads/master@{#314430}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -131 lines) Patch
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/custom_launcher_page_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M apps/custom_launcher_page_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_contents_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_host_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/apps/chrome_app_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_sign_in_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_tabstrip.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chromecast/browser/android/cast_window_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/cast_window_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/shell/browser/shell.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/app_window/app_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/extension_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_host.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/extension_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_app_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_app_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/web_dialog_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/web_dialogs/test/test_web_contents_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/test/test_web_contents_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_delegate.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/web_dialogs/web_dialog_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
bokan
Avi, does this look ok? I renamed the IPC params to match the name change ...
5 years, 10 months ago (2015-02-03 05:03:30 UTC) #2
bokan
Also, if it looks good, can I just TBR the rest since it's a mechanical ...
5 years, 10 months ago (2015-02-03 05:04:24 UTC) #3
Avi (use Gerrit)
lgtm
5 years, 10 months ago (2015-02-03 05:13:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/889403004/20001
5 years, 10 months ago (2015-02-03 22:34:12 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 23:24:14 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/107a47faa8f7e9c38cd0e7aeac74751b103df215 Cr-Commit-Position: refs/heads/master@{#314430}
5 years, 10 months ago (2015-02-03 23:25:06 UTC) #8
dcheng
Please specify actual TBR reviewers next time. I don't think it's OK for code changes ...
5 years, 10 months ago (2015-02-03 23:39:17 UTC) #10
bokan
On 2015/02/03 23:39:17, dcheng wrote: > Please specify actual TBR reviewers next time. I don't ...
5 years, 10 months ago (2015-02-04 20:20:54 UTC) #11
bokan
+kollas@, boliu@, yoz@, and sky@ for after-the-fact manual TBR.
5 years, 10 months ago (2015-02-04 20:48:21 UTC) #13
boliu
On 2015/02/04 20:48:21, bokan wrote: > +kollas@, boliu@, yoz@, and sky@ for after-the-fact manual TBR. ...
5 years, 10 months ago (2015-02-04 21:26:49 UTC) #14
lcwu1
5 years, 10 months ago (2015-02-04 21:29:18 UTC) #16
Message was sent while issue was closed.
chromecast lgtm

Powered by Google App Engine
This is Rietveld 408576698