Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: chrome/browser/ui/browser_tabstrip.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_tabstrip.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_
6 #define CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_ 6 #define CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_
7 7
8 #include "content/public/browser/navigation_controller.h" 8 #include "content/public/browser/navigation_controller.h"
9 #include "content/public/browser/web_contents.h" 9 #include "content/public/browser/web_contents.h"
10 #include "ui/base/page_transition_types.h" 10 #include "ui/base/page_transition_types.h"
(...skipping 19 matching lines...) Expand all
30 void AddTabAt(Browser* browser, const GURL& url, int index, bool foreground); 30 void AddTabAt(Browser* browser, const GURL& url, int index, bool foreground);
31 31
32 // Adds a selected tab with the specified URL and transition, returns the 32 // Adds a selected tab with the specified URL and transition, returns the
33 // created WebContents. 33 // created WebContents.
34 content::WebContents* AddSelectedTabWithURL(Browser* browser, 34 content::WebContents* AddSelectedTabWithURL(Browser* browser,
35 const GURL& url, 35 const GURL& url,
36 ui::PageTransition transition); 36 ui::PageTransition transition);
37 37
38 // Creates a new tab with the already-created WebContents 'new_contents'. 38 // Creates a new tab with the already-created WebContents 'new_contents'.
39 // The window for the added contents will be reparented correctly when this 39 // The window for the added contents will be reparented correctly when this
40 // method returns. If |disposition| is NEW_POPUP, |pos| should hold the 40 // method returns. If |disposition| is NEW_POPUP, |initial_rect| should hold
41 // initial position. If |was_blocked| is non-NULL, then |*was_blocked| will be 41 // the initial position and size. If |was_blocked| is non-NULL, then
42 // set to true if the popup gets blocked, and left unchanged otherwise. 42 // |*was_blocked| will be set to true if the popup gets blocked, and left
43 // unchanged otherwise.
43 void AddWebContents(Browser* browser, 44 void AddWebContents(Browser* browser,
44 content::WebContents* source_contents, 45 content::WebContents* source_contents,
45 content::WebContents* new_contents, 46 content::WebContents* new_contents,
46 WindowOpenDisposition disposition, 47 WindowOpenDisposition disposition,
47 const gfx::Rect& initial_pos, 48 const gfx::Rect& initial_rect,
48 bool user_gesture, 49 bool user_gesture,
49 bool* was__blocked); 50 bool* was__blocked);
50 51
51 // Closes the specified WebContents in the specified Browser. If 52 // Closes the specified WebContents in the specified Browser. If
52 // |add_to_history| is true, an entry in the historical tab database is created. 53 // |add_to_history| is true, an entry in the historical tab database is created.
53 void CloseWebContents(Browser* browser, 54 void CloseWebContents(Browser* browser,
54 content::WebContents* contents, 55 content::WebContents* contents,
55 bool add_to_history); 56 bool add_to_history);
56 57
57 } // namespace chrome 58 } // namespace chrome
58 59
59 #endif // CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_ 60 #endif // CHROME_BROWSER_UI_BROWSER_TABSTRIP_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/browser_tabstrip.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698