chrome/browser/background/background_contents.h - Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/background/background_contents.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/chrome_web_contents_delegate_android.cc ('k') | chrome/browser/background/background_contents.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/background/background_contents.h

diff --git a/chrome/browser/background/background_contents.h b/chrome/browser/background/background_contents.h

index 59711e4b82af8f5391be56a98e296de3aa50b27f..e7345e344c7c6572da0f1e721f105d6c3e941742 100644

--- a/chrome/browser/background/background_contents.h

+++ b/chrome/browser/background/background_contents.h

@@ -36,7 +36,7 @@ class BackgroundContents : public content::WebContentsDelegate,

// set to true if the popup gets blocked, and left unchanged otherwise.

virtual void AddWebContents(content::WebContents* new_contents,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture,

bool* was_blocked) = 0;

@@ -63,7 +63,7 @@ class BackgroundContents : public content::WebContentsDelegate,

void AddNewContents(content::WebContents* source,

content::WebContents* new_contents,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture,

bool* was_blocked) override;

bool IsNeverVisible(content::WebContents* web_contents) override;

« no previous file with comments | « chrome/browser/android/chrome_web_contents_delegate_android.cc ('k') | chrome/browser/background/background_contents.cc » ('j') | no next file with comments »