content/browser/web_contents/web_contents_impl.h - Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index afec26589a3a740ec16585aa5de561f8a86f215e..e62e9958d10b7a9af0d07d4321ffd120cbc2ebd0 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -473,9 +473,9 @@ class CONTENT_EXPORT WebContentsImpl

void CreateNewFullscreenWidget(int render_process_id, int route_id) override;

void ShowCreatedWindow(int route_id,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture) override;

- void ShowCreatedWidget(int route_id, const gfx::Rect& initial_pos) override;

+ void ShowCreatedWidget(int route_id, const gfx::Rect& initial_rect) override;

void ShowCreatedFullscreenWidget(int route_id) override;

void RequestMediaAccessPermission(

const MediaStreamRequest& request,

@@ -887,7 +887,7 @@ class CONTENT_EXPORT WebContentsImpl

// Helper for ShowCreatedWidget/ShowCreatedFullscreenWidget.

void ShowCreatedWidget(int route_id,

bool is_fullscreen,

- const gfx::Rect& initial_pos);

+ const gfx::Rect& initial_rect);

// Finds the new RenderWidgetHost and returns it. Note that this can only be

// called once as this call also removes it from the internal map.

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »