ResizeSynchronously should resize the visible viewport as well.

ResizeSynchronously should resize the visible viewport as well.

The visible viewport is the area of the window that is visible. For example,
when the on-screen keyboard obscures part of the window we shrink the visible
viewport to allow the page to "overscroll" the obscured area into view.
When we resize the window, the visible viewport should be resized along
with it.

Also renamed ResizeSynchronously since it sets the rect, not just the size.
Same for initial_pos_.

This was breaking the
css3/viewport-percentage-lengths/viewport-percentage-lengths-resize.html
layout test upon turning on virtual-viewport.

BUG=444952
Committed: https://crrev.com/c007c3a258816c2f6f6ccf7fc808887a03b0a26d
Cr-Commit-Position: refs/heads/master@{#314282}

[bokan, 2015-02-02 23:28:39]

bokan@chromium.org changed reviewers:
+ avi@chromium.org

[bokan, 2015-02-02 23:28:50]

Hi Avi, ptal. Thanks!

[Avi (use Gerrit), 2015-02-03 01:30:42]

Code is fine; all the variable names aren't.

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:4042: gfx::Rect
new_position(rootWindowRect().x,
rename; "position" doesn't make sense for a rect

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:847: void
RenderWidget::ResizeSynchronously(const gfx::Rect& new_position) {
ditto

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:1618: ResizeSynchronously(pos);
ditto

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
content/renderer/render_widget.h:403: void ResizeSynchronously(const gfx::Rect&
new_position);
ditto

[bokan, 2015-02-03 03:13:18]

Also renamed ResizeSynchronously and initial_pos_ in light of the fact they take
Rects. initial_pos_ gets passed in to some IPCs that take a Rect but also call
it a pos, I'll clean that up in a follow-up CL since there's lots of files to
touch.

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_view...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_view...
content/renderer/render_view_impl.cc:4042: gfx::Rect
new_position(rootWindowRect().x,
On 2015/02/03 01:30:42, Avi wrote:
> rename; "position" doesn't make sense for a rect

Done.

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:847: void
RenderWidget::ResizeSynchronously(const gfx::Rect& new_position) {
On 2015/02/03 01:30:42, Avi wrote:
> ditto

Done.

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
content/renderer/render_widget.cc:1618: ResizeSynchronously(pos);
On 2015/02/03 01:30:42, Avi wrote:
> ditto

Done.

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/894193003/diff/1/content/renderer/render_widg...
content/renderer/render_widget.h:403: void ResizeSynchronously(const gfx::Rect&
new_position);
On 2015/02/03 01:30:42, Avi wrote:
> ditto

Done.

[Avi (use Gerrit), 2015-02-03 03:17:45]

lgtm

[bokan, 2015-02-03 05:00:44]

The CQ bit was checked by bokan@chromium.org

[commit-bot: I haz the power, 2015-02-03 05:01:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/894193003/20001

[commit-bot: I haz the power, 2015-02-03 07:16:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-03 07:17:20]

Patchset 2 (id:??) landed as
https://crrev.com/c007c3a258816c2f6f6ccf7fc808887a03b0a26d
Cr-Commit-Position: refs/heads/master@{#314282}