extensions/browser/app_window/app_window.cc - Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index fe9b75826db0b38d2566f463df12b2d2dc5fe933..9256228d5e861513999488361282932837ddef80 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -373,14 +373,14 @@ WebContents* AppWindow::OpenURLFromTab(WebContents* source,

void AppWindow::AddNewContents(WebContents* source,

WebContents* new_contents,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture,

bool* was_blocked) {

DCHECK(new_contents->GetBrowserContext() == browser_context_);

app_delegate_->AddNewContents(browser_context_,

new_contents,

disposition,

- initial_pos,

+ initial_rect,

user_gesture,

was_blocked);

}

« no previous file with comments | « extensions/browser/app_window/app_window.h ('k') | extensions/browser/extension_host.h » ('j') | no next file with comments »