Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: extensions/shell/browser/shell_extension_host_delegate.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/shell_extension_host_delegate.h" 5 #include "extensions/shell/browser/shell_extension_host_delegate.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "extensions/shell/browser/media_capture_util.h" 8 #include "extensions/shell/browser/media_capture_util.h"
9 #include "extensions/shell/browser/shell_extension_web_contents_observer.h" 9 #include "extensions/shell/browser/shell_extension_web_contents_observer.h"
10 10
(...skipping 18 matching lines...) Expand all
29 ShellExtensionHostDelegate::GetJavaScriptDialogManager() { 29 ShellExtensionHostDelegate::GetJavaScriptDialogManager() {
30 // TODO(jamescook): Create a JavaScriptDialogManager or reuse the one from 30 // TODO(jamescook): Create a JavaScriptDialogManager or reuse the one from
31 // content_shell. 31 // content_shell.
32 NOTREACHED(); 32 NOTREACHED();
33 return NULL; 33 return NULL;
34 } 34 }
35 35
36 void ShellExtensionHostDelegate::CreateTab(content::WebContents* web_contents, 36 void ShellExtensionHostDelegate::CreateTab(content::WebContents* web_contents,
37 const std::string& extension_id, 37 const std::string& extension_id,
38 WindowOpenDisposition disposition, 38 WindowOpenDisposition disposition,
39 const gfx::Rect& initial_pos, 39 const gfx::Rect& initial_rect,
40 bool user_gesture) { 40 bool user_gesture) {
41 // TODO(jamescook): Should app_shell support opening popup windows? 41 // TODO(jamescook): Should app_shell support opening popup windows?
42 NOTREACHED(); 42 NOTREACHED();
43 } 43 }
44 44
45 void ShellExtensionHostDelegate::ProcessMediaAccessRequest( 45 void ShellExtensionHostDelegate::ProcessMediaAccessRequest(
46 content::WebContents* web_contents, 46 content::WebContents* web_contents,
47 const content::MediaStreamRequest& request, 47 const content::MediaStreamRequest& request,
48 const content::MediaResponseCallback& callback, 48 const content::MediaResponseCallback& callback,
49 const Extension* extension) { 49 const Extension* extension) {
50 // Allow access to the microphone and/or camera. 50 // Allow access to the microphone and/or camera.
51 media_capture_util::GrantMediaStreamRequest( 51 media_capture_util::GrantMediaStreamRequest(
52 web_contents, request, callback, extension); 52 web_contents, request, callback, extension);
53 } 53 }
54 54
55 bool ShellExtensionHostDelegate::CheckMediaAccessPermission( 55 bool ShellExtensionHostDelegate::CheckMediaAccessPermission(
56 content::WebContents* web_contents, 56 content::WebContents* web_contents,
57 const GURL& security_origin, 57 const GURL& security_origin,
58 content::MediaStreamType type, 58 content::MediaStreamType type,
59 const Extension* extension) { 59 const Extension* extension) {
60 media_capture_util::VerifyMediaAccessPermission(type, extension); 60 media_capture_util::VerifyMediaAccessPermission(type, extension);
61 return true; 61 return true;
62 } 62 }
63 63
64 } // namespace extensions 64 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/shell/browser/shell_extension_host_delegate.h ('k') | ui/views/controls/webview/web_dialog_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698