ui/views/controls/webview/web_dialog_view.h - Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/web_dialog_view.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/webview/web_dialog_view.h

diff --git a/ui/views/controls/webview/web_dialog_view.h b/ui/views/controls/webview/web_dialog_view.h

index ce69cfc7968e8273090d43c5a70024b544cdd836..22550dd360cc2ef16c86b199a87352736883f445 100644

--- a/ui/views/controls/webview/web_dialog_view.h

+++ b/ui/views/controls/webview/web_dialog_view.h

@@ -103,7 +103,7 @@ class WEBVIEW_EXPORT WebDialogView : public views::ClientView,

void AddNewContents(content::WebContents* source,

content::WebContents* new_contents,

WindowOpenDisposition disposition,

- const gfx::Rect& initial_pos,

+ const gfx::Rect& initial_rect,

bool user_gesture,

bool* was_blocked) override;

void LoadingStateChanged(content::WebContents* source,

« no previous file with comments | « extensions/shell/browser/shell_extension_host_delegate.cc ('k') | ui/views/controls/webview/web_dialog_view.cc » ('j') | no next file with comments »