Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: ui/views/controls/webview/web_dialog_view.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/webview/web_dialog_view.h ('k') | ui/web_dialogs/test/test_web_contents_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/webview/web_dialog_view.cc
diff --git a/ui/views/controls/webview/web_dialog_view.cc b/ui/views/controls/webview/web_dialog_view.cc
index 0bffda9c7e4ddad39f5327b4fb13a21ec661c044..8fe27bf0a76d47903f7f0a562268adf80aa227f0 100644
--- a/ui/views/controls/webview/web_dialog_view.cc
+++ b/ui/views/controls/webview/web_dialog_view.cc
@@ -306,15 +306,15 @@ content::WebContents* WebDialogView::OpenURLFromTab(
void WebDialogView::AddNewContents(content::WebContents* source,
content::WebContents* new_contents,
WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
+ const gfx::Rect& initial_rect,
bool user_gesture,
bool* was_blocked) {
if (delegate_ && delegate_->HandleAddNewContents(
- source, new_contents, disposition, initial_pos, user_gesture)) {
+ source, new_contents, disposition, initial_rect, user_gesture)) {
return;
}
WebDialogWebContentsDelegate::AddNewContents(
- source, new_contents, disposition, initial_pos, user_gesture,
+ source, new_contents, disposition, initial_rect, user_gesture,
was_blocked);
}
« no previous file with comments | « ui/views/controls/webview/web_dialog_view.h ('k') | ui/web_dialogs/test/test_web_contents_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698