Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 int route_id, 466 int route_id,
467 int main_frame_route_id, 467 int main_frame_route_id,
468 const ViewHostMsg_CreateWindow_Params& params, 468 const ViewHostMsg_CreateWindow_Params& params,
469 SessionStorageNamespace* session_storage_namespace) override; 469 SessionStorageNamespace* session_storage_namespace) override;
470 void CreateNewWidget(int render_process_id, 470 void CreateNewWidget(int render_process_id,
471 int route_id, 471 int route_id,
472 blink::WebPopupType popup_type) override; 472 blink::WebPopupType popup_type) override;
473 void CreateNewFullscreenWidget(int render_process_id, int route_id) override; 473 void CreateNewFullscreenWidget(int render_process_id, int route_id) override;
474 void ShowCreatedWindow(int route_id, 474 void ShowCreatedWindow(int route_id,
475 WindowOpenDisposition disposition, 475 WindowOpenDisposition disposition,
476 const gfx::Rect& initial_pos, 476 const gfx::Rect& initial_rect,
477 bool user_gesture) override; 477 bool user_gesture) override;
478 void ShowCreatedWidget(int route_id, const gfx::Rect& initial_pos) override; 478 void ShowCreatedWidget(int route_id, const gfx::Rect& initial_rect) override;
479 void ShowCreatedFullscreenWidget(int route_id) override; 479 void ShowCreatedFullscreenWidget(int route_id) override;
480 void RequestMediaAccessPermission( 480 void RequestMediaAccessPermission(
481 const MediaStreamRequest& request, 481 const MediaStreamRequest& request,
482 const MediaResponseCallback& callback) override; 482 const MediaResponseCallback& callback) override;
483 bool CheckMediaAccessPermission(const GURL& security_origin, 483 bool CheckMediaAccessPermission(const GURL& security_origin,
484 MediaStreamType type) override; 484 MediaStreamType type) override;
485 SessionStorageNamespace* GetSessionStorageNamespace( 485 SessionStorageNamespace* GetSessionStorageNamespace(
486 SiteInstance* instance) override; 486 SiteInstance* instance) override;
487 SessionStorageNamespaceMap GetSessionStorageNamespaceMap() override; 487 SessionStorageNamespaceMap GetSessionStorageNamespaceMap() override;
488 FrameTree* GetFrameTree() override; 488 FrameTree* GetFrameTree() override;
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
880 880
881 // Helper for CreateNewWidget/CreateNewFullscreenWidget. 881 // Helper for CreateNewWidget/CreateNewFullscreenWidget.
882 void CreateNewWidget(int render_process_id, 882 void CreateNewWidget(int render_process_id,
883 int route_id, 883 int route_id,
884 bool is_fullscreen, 884 bool is_fullscreen,
885 blink::WebPopupType popup_type); 885 blink::WebPopupType popup_type);
886 886
887 // Helper for ShowCreatedWidget/ShowCreatedFullscreenWidget. 887 // Helper for ShowCreatedWidget/ShowCreatedFullscreenWidget.
888 void ShowCreatedWidget(int route_id, 888 void ShowCreatedWidget(int route_id,
889 bool is_fullscreen, 889 bool is_fullscreen,
890 const gfx::Rect& initial_pos); 890 const gfx::Rect& initial_rect);
891 891
892 // Finds the new RenderWidgetHost and returns it. Note that this can only be 892 // Finds the new RenderWidgetHost and returns it. Note that this can only be
893 // called once as this call also removes it from the internal map. 893 // called once as this call also removes it from the internal map.
894 RenderWidgetHostView* GetCreatedWidget(int route_id); 894 RenderWidgetHostView* GetCreatedWidget(int route_id);
895 895
896 // Finds the new WebContentsImpl by route_id, initializes it for 896 // Finds the new WebContentsImpl by route_id, initializes it for
897 // renderer-initiated creation, and returns it. Note that this can only be 897 // renderer-initiated creation, and returns it. Note that this can only be
898 // called once as this call also removes it from the internal map. 898 // called once as this call also removes it from the internal map.
899 WebContentsImpl* GetCreatedWindow(int route_id); 899 WebContentsImpl* GetCreatedWindow(int route_id);
900 900
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
1273 // Adds/removes a callback called on creation of each new WebContents. 1273 // Adds/removes a callback called on creation of each new WebContents.
1274 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1274 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1275 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1275 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1276 1276
1277 DISALLOW_COPY_AND_ASSIGN(FriendZone); 1277 DISALLOW_COPY_AND_ASSIGN(FriendZone);
1278 }; 1278 };
1279 1279
1280 } // namespace content 1280 } // namespace content
1281 1281
1282 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1282 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_base.h ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698