Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: extensions/shell/browser/shell_app_delegate.cc

Issue 889403004: Rename initial_pos to initial_rect in ShowWidget and ShowView IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/browser/shell_app_delegate.h" 5 #include "extensions/shell/browser/shell_app_delegate.h"
6 6
7 #include "content/public/browser/web_contents.h" 7 #include "content/public/browser/web_contents.h"
8 #include "extensions/common/constants.h" 8 #include "extensions/common/constants.h"
9 #include "extensions/shell/browser/media_capture_util.h" 9 #include "extensions/shell/browser/media_capture_util.h"
10 10
(...skipping 24 matching lines...) Expand all
35 content::BrowserContext* context, 35 content::BrowserContext* context,
36 content::WebContents* source, 36 content::WebContents* source,
37 const content::OpenURLParams& params) { 37 const content::OpenURLParams& params) {
38 NOTIMPLEMENTED(); 38 NOTIMPLEMENTED();
39 return NULL; 39 return NULL;
40 } 40 }
41 41
42 void ShellAppDelegate::AddNewContents(content::BrowserContext* context, 42 void ShellAppDelegate::AddNewContents(content::BrowserContext* context,
43 content::WebContents* new_contents, 43 content::WebContents* new_contents,
44 WindowOpenDisposition disposition, 44 WindowOpenDisposition disposition,
45 const gfx::Rect& initial_pos, 45 const gfx::Rect& initial_rect,
46 bool user_gesture, 46 bool user_gesture,
47 bool* was_blocked) { 47 bool* was_blocked) {
48 NOTIMPLEMENTED(); 48 NOTIMPLEMENTED();
49 } 49 }
50 50
51 content::ColorChooser* ShellAppDelegate::ShowColorChooser( 51 content::ColorChooser* ShellAppDelegate::ShowColorChooser(
52 content::WebContents* web_contents, 52 content::WebContents* web_contents,
53 SkColor initial_color) { 53 SkColor initial_color) {
54 NOTIMPLEMENTED(); 54 NOTIMPLEMENTED();
55 return NULL; 55 return NULL;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 content::WebContents* web_contents) { 93 content::WebContents* web_contents) {
94 return true; 94 return true;
95 } 95 }
96 96
97 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) { 97 void ShellAppDelegate::SetTerminatingCallback(const base::Closure& callback) {
98 // TODO(jamescook): Should app_shell continue to close the app window 98 // TODO(jamescook): Should app_shell continue to close the app window
99 // manually or should it use a browser termination callback like Chrome? 99 // manually or should it use a browser termination callback like Chrome?
100 } 100 }
101 101
102 } // namespace extensions 102 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/shell/browser/shell_app_delegate.h ('k') | extensions/shell/browser/shell_extension_host_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698